Commit Graph

7414 Commits (ff7b10e5af5732389cac5479ea351c6e551fe24d)

Author SHA1 Message Date
Richard Hansen ff7b10e5af WORK IN PROGRESS 2021-09-10 01:54:40 -04:00
Richard Hansen 5bc4638d3a pad_editor: Call `focusOnLine()` on line number click 2021-09-10 01:54:40 -04:00
Richard Hansen f70f3197b6 pad_editor: Unexport unnecessarily exported `focusOnLine()` 2021-09-10 01:54:40 -04:00
Richard Hansen e22639edac pad_editor: Invert `focusOnLine()` conditions to improve readability 2021-09-10 01:54:40 -04:00
Richard Hansen 373d4fb0fb collab_client: Delete unused `callWhenNotCommitting()` 2021-09-10 01:54:40 -04:00
Richard Hansen 1adf24db79 collab_client: Implement `callWhenNotCommitting()` with a `Gate` 2021-09-10 01:54:40 -04:00
Richard Hansen e5375fe425 collab_client: Use class syntax to improve readability 2021-09-10 01:54:40 -04:00
Richard Hansen 5f80c3f3c9 collab_client: Move task queue class definition to top of file 2021-09-10 01:54:40 -04:00
Richard Hansen 0dc66e629e collab_client: Rename function for consistency 2021-09-10 01:54:40 -04:00
Richard Hansen f26cc7f707 collab_client: Delete unnecessary `getSocket()` helper 2021-09-10 01:54:40 -04:00
Richard Hansen f564e72792 collab_client: Replace `valuesArray()` function with `Object.values()` 2021-09-10 01:54:40 -04:00
Richard Hansen 0c95f2e65e collab_client: Delete unused `options` argument 2021-09-10 01:54:40 -04:00
Richard Hansen 8ef84e5350 pad: Fix initialization race condition
Ensure that `padeditbar.init()` is called before setting up
`pad.collabClient` to avoid the following exception when there is an
error connecting:

    TypeError: Cannot read property 'length' of undefined
        at Object.toggleDropDown
        at Object.showModal
        at Object.disconnected
        at r.<anonymous>
        at r.emit
        at r.onevent
        at r.onpacket
        at r.<anonymous>
        at r.emit
        at r.ondecoded
2021-09-10 01:54:26 -04:00
Richard Hansen a18f5de0fc collab_client: Defer sending messages until connected
This avoids filling the server logs with "Dropping pre-CLIENT_READY
message" error messages.
2021-09-10 01:48:41 -04:00
Richard Hansen 1ff228391d collab_client: Set CONNECTED after sending CLIENT_READY
This makes it possible to defer actions until after the CLIENT_READY
message is sent to the server.
2021-09-10 01:48:41 -04:00
Richard Hansen 05f6e196ae collab_client: Set CONNECTED from `pad.js` 2021-09-10 01:48:41 -04:00
Richard Hansen 966ba54874 collab_client: Promisify deferred actions 2021-09-10 01:48:40 -04:00
Richard Hansen 5814b76aa4 collab_client: Delete unused deferred action `tag` 2021-09-10 01:48:40 -04:00
Richard Hansen 67e7a822e8 collab_client: Treat RECONNECTING the same as CONNECTING 2021-09-10 01:48:40 -04:00
Richard Hansen 02ae7f5c36 collab_client: Always run deferred actions on connect 2021-09-10 01:48:40 -04:00
Richard Hansen 54a746ce94 collab_client: Fix connection timeout logic 2021-09-10 01:48:40 -04:00
Richard Hansen 60dde4edf6 collab_client: Defer on any non-CONNECTED state 2021-09-10 01:48:40 -04:00
Richard Hansen 3f7745b48b collab_client: Invert condition to improve readability 2021-09-10 01:48:40 -04:00
Richard Hansen 03275ba227 deps: Regenerate `src/package-lock.json` 2021-09-06 14:47:11 -04:00
Richard Hansen 59ebaa78fd deps: Update `src/package.json` versions to match lock file 2021-09-06 14:47:11 -04:00
Richard Hansen ebe05f8e63 deps: Delete unused `async-stacktrace` dependency 2021-09-06 14:47:11 -04:00
Richard Hansen bc9cdd6957 SocketIORouter: Add acknowledgement support 2021-09-06 14:45:26 -04:00
Richard Hansen 9f9adb369b SocketIORouter: Don't crash if message handler throws 2021-09-06 14:45:26 -04:00
Richard Hansen 320e5c1109 SocketIORouter: Add unit tests 2021-09-06 14:45:26 -04:00
Richard Hansen 94f71bd5e9 SocketIORouter: Add ability to unregister handler
This will make it easier to add tests.
2021-09-06 14:45:26 -04:00
Richard Hansen 2e93fca699 SocketIORouter: Logging improvements 2021-09-06 14:45:26 -04:00
Richard Hansen b9609a749d SocketIORouter: Rename variables to improve readability 2021-09-06 14:45:26 -04:00
Richard Hansen 4a09000ca6 installDeps.sh: Don't nuke `src/node_modules` on error
Rationale:
  * Clearing out `src/node_modules` is unlikely to bring future
    success.
  * If there is an error, it's better to leave the filesystem alone so
    that the user can investigate the cause.
  * Deleting the directory on error is a surprising behavior.
2021-09-05 19:42:29 -04:00
Richard Hansen 2ba85dba0e installDeps.sh: Handle errors 2021-09-05 19:36:05 -04:00
Richard Hansen 258b8366e2 installDeps.sh: Ensure that `ep_etherpad-lite` is a directory 2021-09-05 19:31:06 -04:00
Richard Hansen cf7cf8be69 installDeps.sh: Quote underquoted expansions 2021-09-05 19:28:58 -04:00
Richard Hansen 8b89cb3f6f installDeps.sh: Wrap long lines 2021-09-05 19:24:17 -04:00
Richard Hansen 42e59ff2cd installDeps.sh: Simplify log message 2021-09-05 19:23:01 -04:00
Myzel394 15964345f7 fixed typo 2021-08-31 16:00:12 +01:00
Richard Hansen 348bc0c269 tests: Delete overly aggressive timeouts
See https://github.com/ether/etherpad-lite/issues/4988 for rationale.
2021-08-30 02:02:37 -04:00
Richard Hansen 67dfb64095 deps: Bump ueberdb2 to 1.4.15 2021-08-30 01:49:02 -04:00
Richard Hansen 942b686f2d deps: Bump npm to 6.14.15 2021-08-30 01:22:44 -04:00
Richard Hansen 1e20936b5b deps: Bump terser to 5.7.2 2021-08-29 23:37:06 -04:00
Richard Hansen f5657510be deps: Bump supertest to 6.1.6 2021-08-29 23:37:06 -04:00
Richard Hansen 327989ef0b deps: Bump superagent to 6.1.0 2021-08-29 23:37:06 -04:00
Richard Hansen 96e66aab17 deps: Bump sinon to 11.1.2 2021-08-29 23:37:06 -04:00
Richard Hansen c33a2682f9 deps: Bump semver to 7.3.5 2021-08-29 23:37:06 -04:00
Richard Hansen 550c7365c2 deps: Bump openapi-backend to 4.2.0 2021-08-29 23:37:06 -04:00
Richard Hansen 529d2f6b7d deps: Bump rehype to 10.0.0 2021-08-29 23:37:06 -04:00
Richard Hansen 0accdf0a07 deps: Bump mocha to 9.1.1 2021-08-29 23:37:06 -04:00