Commit Graph

6623 Commits (e8e90ac207440cf03175cd5f82e6c999bf9d2633)

Author SHA1 Message Date
John McLear e8e90ac207 various timeout changes 2021-01-27 21:51:22 +00:00
John McLear 189786979f various timeout changes 2021-01-27 21:50:18 +00:00
John McLear c43de8ea59 lint and test timeouts for importexportGetPost.js 2021-01-27 21:25:23 +00:00
John McLear ac420f4683 lint and test timeouts for webaccess.js 2021-01-27 21:18:39 +00:00
John McLear 5aa0ad3f55 lint and test timeouts for specialpages.js 2021-01-27 21:18:28 +00:00
John McLear ae49fcf1ae lint and test timeouts for socketio.js 2021-01-27 21:18:17 +00:00
John McLear d12dbc7f63 lint and test timeouts for caching_middleware.js 2021-01-27 21:18:08 +00:00
John McLear fd7a7b4c6c lint and test timeouts for importexportGetPost.js 2021-01-27 21:17:58 +00:00
John McLear 6f364b065d lint and timeouts for sessionAndGroups.js 2021-01-27 20:45:40 +00:00
John McLear 3d69773cd2 lint and timeouts for pad.js 2021-01-27 20:45:31 +00:00
John McLear e5d80a0696 lint and timeouts for instance.js 2021-01-27 20:45:23 +00:00
John McLear 8fff1db4d0 lint and timeouts for importexport.js 2021-01-27 20:33:36 +00:00
John McLear 02bb5a5b73 lint and timeouts for chat.js 2021-01-27 20:30:15 +00:00
John McLear f4eeb59b86 line and timeouts for characterEncoding.js 2021-01-27 20:29:14 +00:00
John McLear 103e3398ad api.js lint and timeouts 2021-01-27 20:19:48 +00:00
John McLear ff71e41812 test timeouts for promises.js 2021-01-27 20:14:22 +00:00
John McLear 28617ee9d0 timeout for contentcollector.js 2021-01-27 20:13:04 +00:00
John McLear 7696ec0a02 Merge branch 'develop' of github.com:ether/etherpad-lite into mochawesome 2021-01-27 20:11:53 +00:00
John McLear 96d9a40b04 timeout values and low hanging lint for hooks.js 2021-01-27 20:09:05 +00:00
John McLear 0c9a19bd1b longer timeouts 2021-01-27 05:59:01 +00:00
John McLear 14c2987afc longer timeouts 2021-01-27 05:50:17 +00:00
John McLear 4c825d3060 longer timeouts 2021-01-27 05:48:09 +00:00
John McLear 55ac85473c more realistic timeouts for slower devices 2021-01-27 05:43:48 +00:00
John McLear 5d276944a8 more realistic timeouts for slower devices 2021-01-27 05:38:29 +00:00
John McLear 21736122a0 more realistic timeouts for slower devices 2021-01-27 05:37:54 +00:00
John McLear 2816820785 more realistic timeouts for slower devices 2021-01-27 05:24:33 +00:00
John McLear 928f1ef8ce more realistic timeouts for slower devices 2021-01-27 05:23:33 +00:00
John McLear 53708e69eb more realistic timeouts for slower devices 2021-01-27 05:23:05 +00:00
John McLear a6406663f4 more realistic timeouts for slower devices 2021-01-27 05:22:24 +00:00
John McLear 929859042c more realistic timeouts for slower devices 2021-01-27 05:19:04 +00:00
John McLear 01ac40dc56 more realistic timeouts for slower devices 2021-01-27 05:15:44 +00:00
John McLear 88d99c0d60 more realistic timeouts for slower devices 2021-01-27 05:15:17 +00:00
Richard Hansen e5b45cc984 contentcollector: Delete unnecessary `dom` functions
And move the remaining functions out of the `makeContentCollector()`
function.
2021-01-27 04:59:36 +00:00
Richard Hansen 275f041fbb contentcollector: Simplify child node access 2021-01-27 04:59:36 +00:00
Richard Hansen 1cb5453aeb contentcollector: Skip over non-Text, non-Element Nodes 2021-01-27 04:59:36 +00:00
Richard Hansen 075969aea0 contentcollector: Fix Element tag name fetch
The `name` property is only available on cheerio's Element-like
objects; DOM Element objects do not have a `name` property. Switch to
`dom.tagName()` to fix the logic for browsers.
2021-01-27 04:59:36 +00:00
Richard Hansen e3ec9d9a4c contentcollector: Fix parent node access
The `parent` property is only available on cheerio's Node-like
objects; DOM Node objects do not have a `parent` property. Switch to
the `parentNode` property so that the code works in browsers as well
as cheerio.
2021-01-27 04:59:36 +00:00
Richard Hansen 1d36549152 contentcollector: Delete unnecessary parentheses 2021-01-27 04:59:36 +00:00
Richard Hansen e3a47e48f9 contentcollector: Fix collectContentLineText hook
Before, the hook always ignored the return values provided by the hook
functions. Now the hook functions can change the text by either
returning a string or setting `context.text` to the desired value.

Also drop the `styl` and `cls` context properties. They were never
documented and they were always null.
2021-01-27 04:59:36 +00:00
Richard Hansen 4e220538a1 contentcollector: Use destructuring to improve readability 2021-01-27 04:59:36 +00:00
Richard Hansen b547ce9a47 contentcollector: Invert logic to improve readability 2021-01-27 04:59:36 +00:00
Richard Hansen b811030846 contentcollector: Delete unnecessary truthiness check 2021-01-27 04:59:36 +00:00
Richard Hansen fc2420c244 contentcollector: Fix iteration over child Nodes
In the DOM, `.children` only includes children that are Element
objects. In cheerio 0.22.0, `.children` includes all child Nodes, not
just Elements. Use `dom.numChildNodes()` and `dom.childNode()` so that
browsers behave the same as cheerio.
2021-01-27 04:59:36 +00:00
Richard Hansen d0bfb54c0a contentcollector: Avoid `for..in` iteration of object properties
`for..in` iterates over inherited properties, which is almost never
desired. In most cases there aren't any inherited enumerable
properties so it's not that big of a deal, but in the case of
HTMLCollection it's very bad because it iterates over every entry
twice (once by numerical index and once by name) plus it includes the
`length` property in the iteration.
2021-01-27 04:59:36 +00:00
Richard Hansen 3cfec58948 contentcollector: Rename `dom` functions for consistency with DOM spec 2021-01-27 04:59:36 +00:00
Richard Hansen 8763c3bb29 contentcollector: Fix Element attribute accesses
The `attribs` property is only available on cheerio's Element-like
objects; DOM Element objects do not have an `attribs` property. Switch
to `dom.nodeAttr()` to fix the logic for browsers.
2021-01-27 04:59:36 +00:00
Richard Hansen 99625950c8 contentcollector: Factor out call to `.toLowerCase()` 2021-01-27 04:59:36 +00:00
Richard Hansen dd7fb1babe contentcollector: Document the `dom` object 2021-01-27 04:59:36 +00:00
Richard Hansen 74bb2f76cc contentcollector: Delete unused `domInterface` parameter 2021-01-27 04:59:36 +00:00
Richard Hansen 42c25b2536 openapi: Fix error logging 2021-01-27 04:59:36 +00:00