4b4584c264
ace2_inner: Delete unnecessary `doc` and `root` variables
2021-08-16 00:34:25 -04:00
ec63c15a40
ace2_inner: Simplify document body selection
2021-08-16 00:31:09 -04:00
11c86e677a
ace2_inner: Consistently use `outerWin` and `outerDoc`
2021-08-16 00:31:09 -04:00
98c1ba5808
ace2_inner: Use destructuring assignment to simplify
2021-08-16 00:31:09 -04:00
c7be4f9d2d
ace2_inner: Move `sidedivinner` creation to ace.js
2021-08-16 00:31:09 -04:00
15b1d4cb75
ace2_inner: Build `sidedivinner` programmatically
2021-08-16 00:31:09 -04:00
b80295c228
ace2_inner: Combine declaration and initialization
2021-08-16 00:31:09 -04:00
7a8edc816b
ace2_inner: Replace `initLineNumbers()` with an IIFE
2021-08-16 00:31:09 -04:00
b5bfff43cf
ace2_inner: Delete redundant class assignment
2021-08-16 00:31:08 -04:00
e581ee01f2
ace2_inner: Formatting improvements
2021-08-16 00:30:50 -04:00
0ca5a3459f
Timeslider: Install an error handler
2021-08-14 07:44:05 -04:00
1e22e0102d
Timeslider: Move `<title>` and `<script>` inside `<head>`
2021-08-14 07:44:05 -04:00
b6fba9d66d
Pad: Improve page load error handler
...
* Install the error handler early.
* Include stack trace.
* Remove unnecessary escaping.
* Improve formatting.
* Move to a separate script file.
2021-08-14 07:44:05 -04:00
d4e74fd038
Pad: Add missing `<head>` and `<body>` tags
...
The comment "head and body had been removed intentionally" implies
that the tags were causing some sort of problem, but the commit that
removed them (57075d1545
2021-08-14 07:44:05 -04:00
4a1f21ce34
pad_editbar: Convert snake case to camel case
2021-08-14 07:26:31 -04:00
5478d2ce60
pad_editbar: Use ES6 class syntax for readability
2021-08-14 07:26:31 -04:00
97ccf9e082
pad_editbar: Factor out duplicate code
2021-08-14 07:08:57 -04:00
ee41de4809
pad_editbar: Deprecate the `toggleDropDown` callback
2021-08-14 07:08:57 -04:00
c629ee09a8
pad_editbar: Call the callback asynchronously
...
This follows JavaScript best practices.
2021-08-14 07:08:57 -04:00
148e10821b
pad_editbar: Always call the callback
2021-08-14 07:08:57 -04:00
07e05a92eb
pad_editbar: Call the callback after all work is done
2021-08-14 07:08:57 -04:00
a1b924f746
pad_editbar: Don't pass a callback to `toggleDropDown()`
...
The function is synchronous so there's no point.
2021-08-14 07:08:57 -04:00
59d6a8b321
pad_editbar: Delete unnecessary `returned` variable
2021-08-14 07:01:50 -04:00
a4652d67a0
pad_editbar: Move `commands` up for readability
2021-08-14 07:01:50 -04:00
fda34407f9
pad_editbar: Move `dropdowns` initialization to constructor
...
This avoids null dereference if a buggy caller calls
`toggleDropDown('none')` before `init()`. (Ideally the caller would be
fixed, but this is not always feasible.)
2021-08-14 07:01:34 -04:00
42b0b1bf00
pad_editbar: Move `syncAnimation` out of `padeditbar` IIFE
...
This avoids the need for an IIFE.
2021-08-14 07:01:13 -04:00
ee996f530f
pad_editbar: Remove unnecessary `syncAnimationFn` variable
2021-08-14 07:01:13 -04:00
4b4eef5f4a
pad_editbar: Convert `registerDefaultCommands()` into a method
2021-08-14 07:01:13 -04:00
0d4f147349
pad_editbar: Simplify iteration
2021-08-14 07:01:13 -04:00
11faf6104a
pad_editbar: Convert `bodyKeyEvent()` into a method
2021-08-14 07:01:13 -04:00
b2fe6e3e7e
pad_editbar: Fix invalid use of `this`
2021-08-14 07:01:12 -04:00
b884628a5a
pad_editbar: Use arrow functions for callbacks, IIFEs
2021-08-14 07:01:12 -04:00
bdaa66c346
pad_editbar: Use `this` instead of `self`
2021-08-14 07:01:12 -04:00
118c66e5d0
HTML import: Improve log message for invalid HTML
2021-08-12 13:53:23 -04:00
c816c20bc7
HTML import: Replace cheerio with jsdom to simplify contentcollector
...
Cheerio provides jQuery-like objects but they wrap DOM Node-like
objects that are not 100% API compatible with the DOM spec. Because of
this, contentcollector, which is used in browsers and in Node.js
during HTML import, has until now needed to support two different
APIs. This commit modifies HTML import to use jsdom instead of cheerio
and simplifies contentcollector.
2021-08-12 13:53:23 -04:00
84d6d277d7
Accessibility fix for JAWS screen readers
...
ace.js: removed the role 'application' from innerDocument.body. JAWS
do not read any text from the edit lines if this role is set.
domline.createDomLine: to give JAWS the ability to read the lines
correctly, it is required to set the attribute 'aria-live' to
'assertive'.
2021-08-12 13:48:08 -04:00
15995acc2a
deps: Bump require-kernel and yajsml
...
This brings improvements to the readability of stack traces,
especially in Firefox.
2021-08-09 19:04:42 -04:00
9eadd9988f
Localisation updates from https://translatewiki.net .
2021-08-09 13:03:33 +02:00
33a43b7082
fix: upgrade rate-limiter-flexible from 2.2.2 to 2.2.3
...
Snyk has created this PR to upgrade rate-limiter-flexible from 2.2.2 to 2.2.3.
See this package in npm:
https://www.npmjs.com/package/rate-limiter-flexible
See this project in Snyk:
https://app.snyk.io/org/johnmclear/project/d9a12bfb-7ccd-443f-9e22-f30d339cc8c5?utm_source=github&utm_medium=upgrade-pr
2021-08-02 20:43:44 -04:00
fd4fb8874e
Localisation updates from https://translatewiki.net .
2021-08-02 13:02:54 +02:00
e61888dfe2
ace.js: Don't use srcdoc when creating iframes (see #4975 )
...
Using srcdoc, especially with multiple nested iframes, seems to be
problematic when using `self` in CSP policies.
2021-07-30 03:51:57 -04:00
9fda5adcef
ace2_inner.js: Improve discovery of `sidediv` and `linemetricsdiv`
...
The `Node.nextSibling` property returns the next Node, not the next
Element. If whitespace, an HTML comment, or any other type of
non-Element Node is ever introduced between the Elements then
`.nextSibling` no longer returns the desired Element. Switching to
`Element.nextElementSibling` would work, but finding the Elements by
ID is more readable and future-proof.
2021-07-30 03:51:56 -04:00
0c963a817a
ace2_inner.js: Delete unnecessary `ace_outerWin` variable
2021-07-30 03:51:56 -04:00
8d869ec927
Pad: Delete non-functional debug logging facility
2021-07-30 03:50:23 -04:00
5d39a57507
Pad: Delete dead `ace_getFormattedCode()`
2021-07-30 03:49:35 -04:00
c3af70e5a5
deps: Bump ueberdb2 to 1.4.13
2021-07-30 03:48:36 -04:00
2dbcd00dc6
Localisation updates from https://translatewiki.net .
2021-07-29 13:03:26 +02:00
a9c6ed8701
Localisation updates from https://translatewiki.net .
2021-07-26 13:03:49 +02:00
d723270388
tests: Improve readability of `multipleUsers.js`
...
* Define utility functions above their use to silence lint warnings.
* Use `.css()` instead of `.attr('style')` to manipulate style.
* Pass an object to `.attr()` rather than call once per attribute.
* Take advantage of chaining.
* Inline unnecessary `padUrl` variable.
* Delete some unnecessary comments.
2021-07-25 02:23:50 +02:00
ff39eeafca
tests: Factor out duplicate `getFrameJQuery()`
2021-07-25 02:23:50 +02:00
42026ff771
tests: Add a comment explaining why `Promise.all()` is not used
2021-07-25 02:23:50 +02:00
01184cd1aa
tests: Remove unnecessary `includeJquery` parameter
2021-07-25 02:23:50 +02:00
4a670e96ab
fix: upgrade express-rate-limit from 5.2.6 to 5.3.0
...
Snyk has created this PR to upgrade express-rate-limit from 5.2.6 to 5.3.0.
See this package in npm:
https://www.npmjs.com/package/express-rate-limit
See this project in Snyk:
https://app.snyk.io/org/johnmclear/project/d9a12bfb-7ccd-443f-9e22-f30d339cc8c5?utm_source=github&utm_medium=upgrade-pr
2021-07-23 04:22:23 +00:00
c83bb058d1
PadMessageHandler: Fix stats null dereference
...
It is possible for the stats to be read before the
`expressCreateServer` hook is called (in particular: when there is an
error during startup), which is when the `socketio` variable is set.
Check for non-null `socketio` before attempting to count the number of
socket.io connections.
2021-07-22 13:07:03 -04:00
3d80409236
Localisation updates from https://translatewiki.net .
2021-07-22 13:03:00 +02:00
62093adce5
tests: refactor inclusion of jquery and sendkeys via script tags
...
Readability is increased by explicitly checking if jquery/sendkeys was
already loaded before evaluating it in the context of ace_inner and the
enclosing container (pad.html). Note that sendkeys is no longer
evaluated in the context of ace_outer, as this isn't needed
Also removes some IE 8/9 legacy code
2021-07-21 01:53:05 +02:00
4ceb3ca4c8
Chat: Allow Shift-Enter to insert a newline
2021-07-19 23:44:33 +02:00
cf86ae8b63
Chat: Use `KeyboardEvent.key` instead of deprecated `.which`
2021-07-19 23:44:33 +02:00
faf84f0143
Chat: Display whitespace in chat messages
2021-07-19 23:44:33 +02:00
834e05fc9c
Chat: Use a `<textarea>` for message input
2021-07-19 23:44:33 +02:00
ce5ef9350f
tests: sendkeys: Fix `{enter}` keypress event
2021-07-19 23:44:33 +02:00
c6f643dd75
Localisation updates from https://translatewiki.net .
2021-07-19 13:02:46 +02:00
ca4cc2d7c0
Fix settings.useMonospaceFontGlobal
...
When settings.useMonospaceFontGlobal is set to `true`, it sets the default
font to 'monospace'. This font seems to have been removed in
a5164dad43
2021-07-14 04:33:38 -04:00
336d48add7
Add support for square brackets in URLs
...
This reverts commit 9022877cc6
2021-07-10 22:22:31 -04:00
09f8ffbdb6
deps: Bump ueberdb2 to 1.4.11
2021-07-10 18:26:31 -04:00
5f39a1ee7f
CSS: Underline links in error dialogs
...
Underlining was removed for unknown reasons by commit
d872b42e31
2021-07-09 18:43:13 -04:00
a634bd8ee1
bump version
2021-07-04 07:05:34 +02:00
197e04ecd7
Localisation updates from https://translatewiki.net .
2021-07-01 13:42:31 +02:00
3d40ab7e8c
CSS: Move author color padding to `setAuthorStyle()`
...
This prevents the padding from clashing with plugins that use the
`aceSetAuthorStyle` hook.
2021-06-22 14:43:22 -04:00
2745557127
Localisation updates from https://translatewiki.net .
2021-06-21 12:28:27 +02:00
9fcd86b3cd
Pad: Fix `<script>` elements in `aceInitInnerdocbodyHead` hook
...
Using `.innerHTML` to create a `<script>` element does create a DOM
node, but the script is not actually executed. Fortunately, creating a
DocumentFragment does cause the script to execute.
2021-06-18 17:50:15 -04:00
7bdd0f2f09
bin/updatePlugins.sh: Many refinements
...
* cd to top-level Etherpad directory is now more robust.
* Only attempt to update packages whose names begin with `ep_`.
* Don't create `package-lock.json`.
* Improve logging.
* Improve error handling.
2021-06-18 04:34:37 -04:00
4b3e47bd23
bin/importSqlFile.js: Read the file one line at a time
...
This avoids running out of memory if the file is large.
2021-06-17 19:45:17 -04:00
485538bd79
bump wtfnode to fix #5078
2021-06-17 06:14:45 +02:00
251cc7ab32
CSS: Fix button icon centering
2021-06-16 18:27:52 -04:00
53cca5a743
PadMessageHandler: Also send `USER_NEWINFO` messages on reconnect
...
Now the user list is correct after a reconnect. This also allows
ep_webrtc to automatically recover after a temporary network glitch.
2021-06-16 01:35:25 -04:00
7ca336c28e
lint: Update eslint-config-etherpad and friends
2021-06-14 23:17:17 +02:00
ef1ba21104
deps: Drop support for Node.js < 12.13.0
2021-06-14 23:17:17 +02:00
66ee9c5ef9
update package-lock
2021-06-14 13:21:48 -04:00
5dcb7a7549
tests: Don't attempt to wrap non-functions
2021-06-14 13:45:13 +02:00
081b97c41d
tests: Wrap more Mocha functions
2021-06-14 13:45:13 +02:00
3e4df68510
tests: Enable fake webcam on Microsoft Edge
2021-06-10 15:36:35 -04:00
565b1c5271
tests: Fix flexbox grow/shrink factors
...
* Make sure the `#mocha-report` div grows to fill the available
vertical space.
* Prevent the "Loading frontend test specs..." div from shrinking.
2021-06-10 13:28:55 -04:00
acd11c3948
tests: Fetch frontend test specs in parallel
2021-06-09 20:28:03 -04:00
36d2af5318
tests: Display frontend spec loading progress
2021-06-09 20:18:22 -04:00
e0ae997501
tests: Don't auto-scroll Mocha results if user scrolls up
2021-06-09 18:48:31 -04:00
f5046f4b18
tests: Keep the `#mocha-stats` div visible
2021-06-09 18:48:31 -04:00
ea4500ef64
fix: upgrade express-session from 1.17.1 to 1.17.2
...
Snyk has created this PR to upgrade express-session from 1.17.1 to 1.17.2.
See this package in npm:
https://www.npmjs.com/package/express-session
See this project in Snyk:
https://app.snyk.io/org/johnmclear/project/d9a12bfb-7ccd-443f-9e22-f30d339cc8c5?utm_source=github&utm_medium=upgrade-pr
2021-06-09 22:13:02 +00:00
28f2acf98a
Localisation updates from https://translatewiki.net .
2021-06-07 14:48:08 +02:00
cccabf45b8
pad: Move error message to the top of the gritter box
2021-06-06 21:31:49 -04:00
b2e94685fb
pad: Display error name in the gritter box
2021-06-06 21:31:40 -04:00
63a5dc6599
tests: Configure Firefox to use fake webcam
...
This makes it possible to test ep_webrtc in Firefox.
2021-06-06 16:53:51 -04:00
8f0d70312d
tests: Also pass `--use-fake-ui-for-media-stream` to Chrome
...
For testing ep_webrtc.
2021-06-06 16:25:27 -04:00
752e2488af
tests: Migrate from `wd` to `selenium-webdriver`
2021-06-06 16:23:56 -04:00
1756415495
tests: Avoid jQuery when reading Mocha output
2021-06-06 16:20:13 -04:00
6c2f31a5cb
tests: Add tests for `settings.json` parsing
2021-06-06 14:00:52 -04:00
428f8d1684
Settings: Deprecate null as the default default value
2021-06-06 14:00:52 -04:00
c7bb18c6da
Settings: Support null and undefined env var substitutions
2021-06-06 14:00:51 -04:00
299dbbe7e6
tests: Move split-grid to dev dependencies
...
This is only used for testing.
2021-06-06 06:45:00 -04:00
45ca82fd9f
tests: Make the Mocha results area resizable
2021-06-05 03:51:55 -04:00
c4239b6059
tests: Show a scrollbar if the pad is too wide
2021-06-05 03:51:11 -04:00
fc3b811726
tests: Move iframe min width to iframe selector
2021-06-05 03:51:11 -04:00
960c2c0c0d
tests: Tweak mocha report spacing
2021-06-05 03:51:11 -04:00
b09b895ac7
tests: Remove border around iframe
2021-06-05 03:51:11 -04:00
e9f08bdd11
tests: Fix frontend test CSS selectors
2021-06-05 03:51:11 -04:00
76634eb6ff
tests: Add missing `<head>` and `<body>` tags
2021-06-05 03:51:11 -04:00
d9782ac628
tests: Send frontend test spec list as JSON
2021-06-05 03:51:06 -04:00
20df34bb67
tests: Promisify `helper.init()`
2021-06-05 03:50:36 -04:00
c714ff1014
tests: Let Express handle errors when serving `frontendTestSpecs.js`
...
Express v4.x doesn't understand Promises so we have to manually catch
Promise rejections and pass the error object to `next()`.
2021-06-05 03:50:36 -04:00
e4f011df76
tests: Use `require()` to load frontend test specs
...
This makes core and plugin tests consistent with each other, makes it
possible to `require()` relative paths in spec files, simplifies the
code somewhat, and should make it easier to move away from
require-kernel.
Also:
* Wrap plugin tests inside a `describe()` that contains the plugin
name to make it easier to grep for a plugin's tests and for
consistency with core tests.
* Add "<core>" to the core test descriptions to make it easier to
distinguish them from plugin tests.
2021-06-05 03:50:26 -04:00
d8eb79428f
tests: Recurse under frontend spec dir
2021-06-05 03:49:13 -04:00
5d54c1657a
tests: Redirect `/tests/frontend/index.html` to `/tests/frontend/`
2021-06-05 03:49:12 -04:00
712b8c5769
tests: Redirect `/tests/frontend` to `/tests/frontend/`
2021-06-05 03:49:12 -04:00
573da027e5
tests: Preserve query string when redirecting
2021-06-05 03:49:12 -04:00
9cba96e5e9
tests: Use relative paths for scripts
2021-06-05 03:49:12 -04:00
e144434571
tests: Use relative paths in `helper.init()`
...
This avoids problems if Etherpad is served under a path like
`/etherpad`.
2021-06-05 03:49:12 -04:00
dfd649dbe9
tests: Use a relative redirect for `/tests/frontend`
...
This avoids problems if Etherpad is served under a path like
`/etherpad`.
2021-06-03 15:10:23 -04:00
617267ce71
tests: Use `plugin_defs` to get plugin frontend test spec paths
2021-06-03 15:10:23 -04:00
1b7b96f57e
tests: Avoid deprecated `fs.existsSync()`
2021-06-03 15:10:23 -04:00
ab824c728f
tests: Move slashes to improve readability
2021-06-03 15:10:22 -04:00
1516bf473f
tests: Delete unnecessary `staticDir` variable
2021-06-03 15:10:22 -04:00
d69345bb4e
tests: Use map+reduce to improve readability
2021-06-03 15:10:22 -04:00
a8e77126e8
tests: Combine `.map().filter().map()` into single `.map()`
2021-06-03 15:10:22 -04:00
2414203434
tests: Remove unnecessary `return`
2021-06-03 15:10:22 -04:00
0852df74f1
tests: Unexport unnecessarily exported functions
2021-06-03 15:10:22 -04:00
ed44449639
tests: Pretty-print `frontendTestSpecs.js` to make troubleshooting easier
2021-06-03 15:10:22 -04:00
4fa9f9e9d8
tests: Use `window.foo` instead of `var foo`
2021-06-03 15:10:22 -04:00
aea2fb7448
tests: Rename `specs_list` to `frontendTestSpecs`
2021-06-03 15:10:22 -04:00
1be1b704f1
tests: Simplify iteration over frontend test specs
2021-06-03 15:10:22 -04:00
b85a040f13
tests: Reuse `sanitizePathname` when serving frontend specs
2021-06-03 15:10:22 -04:00
ade17490e0
tests: Combine frontend test file handlers
2021-06-03 15:10:22 -04:00
995e381243
tests: Only wrap `*.js` files in `describe()`
2021-06-03 15:10:22 -04:00
e1c2c963f0
tests: URL decode test spec pathnames
...
Express automatically URL decodes route parameters.
2021-06-03 15:10:22 -04:00
998e77ec25
tests: Switch to promisified `readFile`
2021-06-03 15:10:22 -04:00
6cf27a7133
tests: Use `fs.promises` instead of wrapping with `util.promisify`
2021-06-03 15:10:22 -04:00
f00f9aa14c
tests: Avoid `.then()` inside `async` functions
2021-06-03 15:10:22 -04:00
d87b4e0c20
tests: Use `async`/`await` instead of returning Promises
...
This makes stack traces more useful.
2021-06-03 15:10:21 -04:00
0d9476529e
sanitizePathname: Move to separate module to facilitate reuse
2021-06-03 15:10:21 -04:00
926da57e34
Minify: Refine `sanitizePathname` to avoid pathname traversal
2021-06-03 15:10:21 -04:00
3bca85286b
Localisation updates from https://translatewiki.net .
2021-06-03 15:12:59 +02:00
8f63671ea9
Localisation updates from https://translatewiki.net .
2021-05-31 10:02:43 +02:00
a04089636c
Localisation updates from https://translatewiki.net .
2021-05-27 15:37:31 +02:00
c426e939d1
Localisation updates from https://translatewiki.net .
2021-05-24 14:00:35 +02:00
6f2f20233f
lint: Fix straightforward ESLint errors
2021-05-12 11:26:35 +02:00
59c03bde20
lint: Re-run `eslint --fix`
2021-05-12 11:26:35 +02:00
30eadad79d
lint: Bump ESLint dependencies
2021-05-12 11:26:35 +02:00
24929d3417
package.json: bump npm from 6.14.11 to 6.14.13
2021-05-07 14:58:57 +02:00
10f00906f8
update package-lock.json
2021-05-07 14:58:57 +02:00
ff245dbbeb
fix: upgrade underscore from 1.13.0 to 1.13.1
...
Snyk has created this PR to upgrade underscore from 1.13.0 to 1.13.1.
See this package in npm:
https://www.npmjs.com/package/underscore
See this project in Snyk:
https://app.snyk.io/org/johnmclear/project/d9a12bfb-7ccd-443f-9e22-f30d339cc8c5?utm_source=github&utm_medium=upgrade-pr
2021-05-07 14:27:30 +02:00
4701cc43fa
Localisation updates from https://translatewiki.net .
2021-05-07 10:50:38 +02:00
Richard Hansen