freddii
ea202e41f6
docs: fixed typos
2021-02-03 00:30:07 +01:00
John McLear
65dec5bd2c
lint: json.js
2021-02-02 15:24:12 -05:00
John McLear
3e910b9905
stale: remove convert.js as no one runs old Etherpad
2021-02-01 22:45:51 +00:00
John McLear
9987fab574
lint: low hanging bin/doc/*.js
2021-02-01 13:15:48 -05:00
John McLear
0cc8405e9c
Bump minimum required Node.js version to 10.17.0
...
This makes it possible to use fs.promises.
2021-01-30 17:00:40 -05:00
Richard Hansen
0ad0160b7c
bin/rebuildPad.js: Fix check for existing rev
2021-01-30 07:45:37 +00:00
Richard Hansen
846e3e9fbd
bin/rebuildPad.js: Don't overwrite DB settings
...
There's no need, and setting `json` to true breaks databases that do
their own serialization of ECMAScript objects.
2021-01-30 07:45:37 +00:00
Richard Hansen
bf209ddad3
bin/rebuildPad.js: Close the database when done
...
This prevents loss of data due to unflushed writes.
2021-01-30 07:45:37 +00:00
Richard Hansen
809dc6e367
bin/rebuildPad.js: PadManager must be loaded before Pad
...
There is a circular dependency between the two; loading PadManager
first ensures that PadManager's Pad variable is not undefined.
2021-01-30 07:45:37 +00:00
Richard Hansen
5b519b9a9c
bin/rebuildPad.js: Asyncify
2021-01-30 07:45:37 +00:00
Richard Hansen
72c2abab8d
bin/rebuildPad.js: Fix sequencing of asynchronous functions
2021-01-30 07:45:37 +00:00
Richard Hansen
69efd16a6d
bin/rebuildPad.js: Add missing calls to `util.callbackify`
2021-01-30 07:45:37 +00:00
Richard Hansen
c622894fe0
bin scripts: Promisify db.init and db.close
2021-01-30 07:45:37 +00:00
Richard Hansen
0a61767901
bin scripts: Delete redundant exception log messages
...
The exception will cause Node.js to print the error message and stack
trace so there's no point in logging it ourselves.
2021-01-30 07:45:37 +00:00
Richard Hansen
efdcaae526
bin scripts: Promisify npm.load
2021-01-30 07:45:37 +00:00
Richard Hansen
92cd2cc760
bin scripts: Use destructuring instead of long condition checks
2021-01-30 07:45:37 +00:00
Richard Hansen
f03c4bd7f7
bin scripts: compare against null, not undefined
2021-01-30 07:45:37 +00:00
Richard Hansen
b02ab430fe
Bump eslint-config-etherpad to 1.0.24
2021-01-29 01:10:58 -05:00
John McLear
2fdc737355
bugfix, lint and refactor all bin scripts ( #4617 )
...
* bugfix, lint and refactor all bin scripts
* for squash: throw Error(message) rather than log(message); throw Error()
* for squash: Exit non-0 on unhandled Promise rejection
Many of the recent lint changes have converted normal functions to
async functions, and an error thrown in an async function does not
cause Node.js to exit by default.
* for squash: fix `require()` paths
* for squash: remove erroneous `Object.keys()` call
* for squash: fix missing `continue` statements
* for squash: Fix HTTP method for deleteSession
* for squash: delete erroneous throw
Throw is only for errors, not successful completion.
* for squash: redo migrateDirtyDBtoRealDB.js to fix async bugs
* for squash: fix erroneous use of `for..of`
* for squash: Add line break between statements
* for squash: put closing paren on same line as last arg
* for squash: Move `log()` back up where it was
to minimize the diff to develop
* for squash: indentation fixes
* for squash: typo fix
* for squash: wrap long lines
* for squash: use `util.callbackify` to silence promise/no-callback-in-promise warning
* for squash: use double quotes to improve readability
Co-authored-by: Richard Hansen <rhansen@rhansen.org>
2021-01-18 08:53:15 +00:00
Richard Hansen
edbe6d5387
Bump ueberDB to get speed improvements
2021-01-11 09:23:08 +00:00
Richard Hansen
481fa047e4
checkPlugin: Merge the `autoupdate` option into `autofix`
2021-01-11 08:51:04 +00:00
Richard Hansen
039c50de80
checkPlugin: Make `autocommit` imply `autoupdate`, `autoupdate` imply `autofix`
2021-01-11 08:51:04 +00:00
Richard Hansen
27df9df47f
checkPlugin: Revise README.md
2021-01-11 08:51:04 +00:00
Richard Hansen
adb38d0d61
checkPlugin: Display a diff of the changes
2021-01-11 08:51:04 +00:00
Richard Hansen
6ccbe374d8
checkPlugin: Don't nuke `node_modules/`
...
`git add -A` will ignore `node_modules/` because it's in `.gitignore`.
2021-01-11 08:51:04 +00:00
Richard Hansen
5f2aaea255
checkPlugin: Use git to determine whether there were changes
2021-01-11 08:51:04 +00:00
Richard Hansen
9f4bcfb79b
checkPlugin: Ensure that a peer dep for `ep_etherpad-lite` exists
...
Tweak the new `updateDeps()` function and use it to add the
`ep_etherpad-lite` dependency if it is missing.
2021-01-11 08:51:04 +00:00
Richard Hansen
42da976705
checkPlugin: Move dependency update logic to a generic function
...
This will make it possible to reuse the logic for `peerDependencies`.
2021-01-11 08:51:04 +00:00
Richard Hansen
747f323552
checkPlugin: Use absolute path when installing `ep_etherpad-lite`
...
This makes it possible to check plugins that were installed by
symlinking into `node_modules/` like this:
git clone git@github.com:ether/etherpad-lite.git
git clone git@github.com:ether/ep_example.git
cd etherpad-lite
npm i ep_example@file:../ep_example
node ./bin/checkPlugin.js ep_example
2021-01-11 08:51:04 +00:00
Richard Hansen
b719affe6e
checkPlugin: Unconditionally run `npm install`
2021-01-11 08:51:04 +00:00
Richard Hansen
bba47ea2df
checkPlugin: Make sure `package.json` ends with a newline
2021-01-11 08:51:04 +00:00
Richard Hansen
bf8d55ab8e
checkPlugin: New `writePackageJson()` convenience function
2021-01-11 08:51:04 +00:00
Richard Hansen
b3b9afa668
checkPlugin: Split dirty working directory check into two checks
...
Rather than check for modifications and untracked files in one
command, use two commands: one for modifications and one for untracked
files. This makes the error messages easier to understand, and it
allows us to include `git status`-like output in the modifications
error message.
2021-01-09 22:49:27 +00:00
Richard Hansen
6a13baf7d4
checkPlugin: Use `--name-status` for `git diff-index`
...
`--compact-sumary` is relatively new (v2.17.0), and I actually
intended to use `--name-status` anyway.
2021-01-09 22:49:27 +00:00
Richard Hansen
071cca1d48
checkPlugin: Don't create an empty commit
2021-01-09 08:05:31 +00:00
Richard Hansen
38ca0c52a6
checkPlugin: Add lots of Git sanity checks
2021-01-09 08:05:31 +00:00
Richard Hansen
1a9bfc8d4f
checkPlugin: Don't capture stdout when unnecessary
2021-01-09 08:05:31 +00:00
Richard Hansen
102c01f723
checkPlugin: Move log messages where they make more sense
2021-01-09 08:05:31 +00:00
Richard Hansen
d816bb2b38
checkPlugin: New `execSync()` convenience function
2021-01-09 08:05:31 +00:00
Richard Hansen
a55dd73f2b
Typo fix: `checkPlugins.js` -> `checkPlugin.js`
2021-01-08 19:02:55 -05:00
Richard Hansen
44118c0e7b
checkPlugin: Refine installation of lint dependencies
2021-01-08 19:02:55 -05:00
Richard Hansen
a0d21f75c4
checkPlugin: Add missing lint dependency
2021-01-08 18:42:10 -05:00
Richard Hansen
6890bfada1
checkPlugin: Bump eslint, eslint-config-etherpad versions
2021-01-08 18:24:42 -05:00
Richard Hansen
ba1c468865
checkPlugin: Fix command-line argument parsing bug
2021-01-08 18:07:55 -05:00
John McLear
fd3004faad
checkPlugins: various minor updates ( #4635 )
...
Co-authored-by: Richard Hansen <rhansen@rhansen.org>
2021-01-07 21:52:45 -05:00
Richard Hansen
3373f059e6
Plugin publish workflow: Run `git push` before `npm publish`
2021-01-05 21:59:03 +00:00
John McLear
6012a9a480
scripts: include v in release number to fix rleease script docs
2021-01-05 16:45:14 +00:00
John McLear
4671b275e9
script: various fixes to release script
2020-12-23 16:27:02 -05:00
John McLear
b59461a469
script: include package files in release script logic
2020-12-23 16:18:28 -05:00
John McLear
89ae726221
script: close console log in release script...
2020-12-23 16:18:28 -05:00