public-offering
/
pad.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pad_editbar: Move `dropdowns` initialization to constructor 

This avoids null dereference if a buggy caller calls
`toggleDropDown('none')` before `init()`. (Ideally the caller would be
fixed, but this is not always feasible.)
pull/5152/head
Richard Hansen 2021-07-15 18:05:03 -04:00
parent 42b0b1bf00
commit fda34407f9
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/static/js/pad_editbar.js
View File

@ -124,10 +124,9 @@ const syncAnimation = (() => {
exports.padeditbar = { exports.padeditbar = {
_editbarPosition: 0, _editbarPosition: 0,
dropdowns: [],
init() { init() {
this.dropdowns = [];
$('#editbar .editbarbutton').attr('unselectable', 'on'); // for IE $('#editbar .editbarbutton').attr('unselectable', 'on'); // for IE
this.enable(); this.enable();
$('#editbar [data-key]').each((i, elt) => { $('#editbar [data-key]').each((i, elt) => {