GitHub workflows: Install Etherpad deps after installing plugins

.github/workflows/backend-tests.yml

@@ -49,9 +49,6 @@ jobs:
         sudo apt update
         sudo apt install -y --no-install-recommends libreoffice libreoffice-pdfimport
 
-    - name: Install all dependencies and symlink for ep_etherpad-lite
-      run: bin/installDeps.sh
-
     - name: Install Etherpad plugins
       run: >
         npm install
@@ -68,6 +65,16 @@ jobs:
         ep_subscript_and_superscript
         ep_table_of_contents
 
+    # This must be run after installing the plugins, otherwise npm will try to
+    # hoist common dependencies by removing them from src/node_modules and
+    # installing them in the top-level node_modules. As of v6.14.10, npm's hoist
+    # logic appears to be buggy, because it sometimes removes dependencies from
+    # src/node_modules but fails to add them to the top-level node_modules. Even
+    # if npm correctly hoists the dependencies, the hoisting seems to confuse
+    # tools such as `npm outdated`, `npm update`, and some ESLint rules.
+    - name: Install all dependencies and symlink for ep_etherpad-lite
+      run: bin/installDeps.sh
+
     # configures some settings and runs npm run test
     - name: Run the backend tests
       run: tests/frontend/travis/runnerBackend.sh

.github/workflows/frontend-tests.yml

@@ -55,9 +55,6 @@ jobs:
         TRAVIS_JOB_NUMBER: ${{ github.run_id }}-${{ github.run_number }}-${{ github.job }}
       run: tests/frontend/travis/sauce_tunnel.sh
 
-    - name: Install all dependencies and symlink for ep_etherpad-lite
-      run: bin/installDeps.sh
-
     - name: Install Etherpad plugins
       run: >
         npm install
@@ -74,6 +71,16 @@ jobs:
         ep_subscript_and_superscript
         ep_table_of_contents
 
+    # This must be run after installing the plugins, otherwise npm will try to
+    # hoist common dependencies by removing them from src/node_modules and
+    # installing them in the top-level node_modules. As of v6.14.10, npm's hoist
+    # logic appears to be buggy, because it sometimes removes dependencies from
+    # src/node_modules but fails to add them to the top-level node_modules. Even
+    # if npm correctly hoists the dependencies, the hoisting seems to confuse
+    # tools such as `npm outdated`, `npm update`, and some ESLint rules.
+    - name: Install all dependencies and symlink for ep_etherpad-lite
+      run: bin/installDeps.sh
+
     - name: export GIT_HASH to env
       id: environment
       run: echo "::set-output name=sha_short::$(git rev-parse --short ${{ github.sha }})"

.github/workflows/load-test.yml

@@ -39,9 +39,6 @@ jobs:
     - name: Checkout repository
       uses: actions/checkout@v2
 
-    - name: Install all dependencies and symlink for ep_etherpad-lite
-      run: bin/installDeps.sh
-
     - name: Install etherpad-load-test
       run: sudo npm install -g etherpad-load-test
 
@@ -61,6 +58,16 @@ jobs:
         ep_subscript_and_superscript
         ep_table_of_contents
 
+    # This must be run after installing the plugins, otherwise npm will try to
+    # hoist common dependencies by removing them from src/node_modules and
+    # installing them in the top-level node_modules. As of v6.14.10, npm's hoist
+    # logic appears to be buggy, because it sometimes removes dependencies from
+    # src/node_modules but fails to add them to the top-level node_modules. Even
+    # if npm correctly hoists the dependencies, the hoisting seems to confuse
+    # tools such as `npm outdated`, `npm update`, and some ESLint rules.
+    - name: Install all dependencies and symlink for ep_etherpad-lite
+      run: bin/installDeps.sh
+
     # configures some settings and runs npm run test
     - name: Run load test
       run: tests/frontend/travis/runnerLoadTest.sh