Docker: Invoke npm only once when installing plugins

This speeds up the build process.
pull/4922/head
Richard Hansen 2021-03-02 23:53:12 -05:00 committed by John McLear
parent c07bfe10bd
commit eccec0ba0a
1 changed files with 1 additions and 5 deletions

View File

@ -72,11 +72,7 @@ COPY --chown=etherpad:etherpad ./ ./
RUN src/bin/installDeps.sh && \ RUN src/bin/installDeps.sh && \
rm -rf ~/.npm/_cacache rm -rf ~/.npm/_cacache
# Install the plugins, if ETHERPAD_PLUGINS is not empty. RUN [ -z "${ETHERPAD_PLUGINS}" ] || npm install ${ETHERPAD_PLUGINS}
#
# Bash trick: in the for loop ${ETHERPAD_PLUGINS} is NOT quoted, in order to be
# able to split at spaces.
RUN for PLUGIN_NAME in ${ETHERPAD_PLUGINS}; do npm install "${PLUGIN_NAME}" || exit 1; done
# Copy the configuration file. # Copy the configuration file.
COPY --chown=etherpad:etherpad ./settings.json.docker "${EP_DIR}"/settings.json COPY --chown=etherpad:etherpad ./settings.json.docker "${EP_DIR}"/settings.json