public-offering
/
pad.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tests: Fix erroneous use of `waitForPromise()` in `ordered_list.js` 

`waitForPromise()` should always be used with `await` (either directly
or with a later `await` on the returned Promise). In this case,
the condition should be immediately true so `waitForPromise()` is not
the right tool here.
pull/4737/head
Richard Hansen 2021-02-08 13:18:19 -05:00 committed by John McLear
parent 7baa0cda02
commit e9bb2c410e
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/tests/frontend/specs/ordered_list.js
View File

@ -32,6 +32,7 @@ describe('ordered_list.js', function () {
.done(done);
});
});
context('and pad shortcut is disabled', function () {
beforeEach(async function () {
const originalHTML = helper.padInner$('body').html();
@ -47,7 +48,7 @@ describe('ordered_list.js', function () {
// TODO: Re-throw non-"condition never became true" errors to avoid false positives.
}
// This will fail if the above `waitForPromise()` succeeded.
helper.waitForPromise(() => helper.padInner$('body').html() === originalHTML);
expect(() => helper.padInner$('body').html()).to.be(originalHTML);
});
it('does not insert unordered list', function (done) {
@ -92,7 +93,7 @@ describe('ordered_list.js', function () {
// TODO: Re-throw non-"condition never became true" errors to avoid false positives.
}
// This will fail if the above `waitForPromise()` succeeded.
helper.waitForPromise(() => helper.padInner$('body').html() === originalHTML);
expect(() => helper.padInner$('body').html()).to.be(originalHTML);
});
it('does not insert unordered list', function (done) {