From d9c2778d17caed89bf249d132f734e72b52441fb Mon Sep 17 00:00:00 2001
From: Richard Hansen <rhansen@rhansen.org>
Date: Mon, 22 Feb 2021 04:30:52 -0500
Subject: [PATCH] plugins: Better fix for LGTM security warning

---
 src/static/js/admin/plugins.js | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/static/js/admin/plugins.js b/src/static/js/admin/plugins.js
index 613df3688..d3636dfd8 100644
--- a/src/static/js/admin/plugins.js
+++ b/src/static/js/admin/plugins.js
@@ -84,12 +84,12 @@ $(document).ready(() => {
 
       for (const attr in plugin) {
         if (attr === 'name') { // Hack to rewrite URLS into name
-          const link = $('<a href="">'); // intentional null href
-          link.attr('href', `https://npmjs.org/package/${plugin.name}`);
-          link.attr('plugin', 'Plugin details');
-          link.attr('rel', 'noopener noreferrer');
-          link.attr('target', '_blank');
-          link.text(plugin.name.substr(3));
+          const link = $('<a>')
+              .attr('href', `https://npmjs.org/package/${plugin.name}`)
+              .attr('plugin', 'Plugin details')
+              .attr('rel', 'noopener noreferrer')
+              .attr('target', '_blank')
+              .text(plugin.name.substr(3));
           row.find('.name').append(link);
         } else {
           row.find(`.${attr}`).text(plugin[attr]);