public-offering
/
pad.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

wait for test to not fail

list-test-fix
John McLear 2021-02-08 07:56:11 +00:00
parent d1c66123dd
commit c8c78987d8
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/tests/frontend/specs/ordered_list.js
View File

@ -39,14 +39,15 @@ describe('ordered_list.js', function () {
triggerCtrlShiftShortcut('N');
try {
// The HTML should not change. Briefly wait for it to change and fail if it does change.
await helper.waitForPromise(() => helper.padInner$('body').html() !== originalHTML, 500);
await helper.waitForPromise(
() => helper.padInner$('body').html() !== originalHTML, 500);
} catch (err) {
// We want the test to pass if the above wait timed out. (If it timed out that
// means the HTML never changed, which is a good thing.)
// TODO: Re-throw non-"condition never became true" errors to avoid false positives.
}
// This will fail if the above `waitForPromise()` succeeded.
assert.equal(helper.padInner$('body').html(), originalHTML);
helper.waitForPromise(() => helper.padInner$('body').html() === originalHTML);
});
it('does not insert unordered list', function (done) {
@ -81,7 +82,17 @@ describe('ordered_list.js', function () {
const originalHTML = helper.padInner$('body').html();
makeSureShortcutIsDisabled('cmdShift1');
triggerCtrlShiftShortcut('1');
await helper.waitForPromise(() => helper.padInner$('body').html() === originalHTML);
try {
// The HTML should not change. Briefly wait for it to change and fail if it does change.
await helper.waitForPromise(
() => helper.padInner$('body').html() !== originalHTML, 500);
} catch (err) {
// We want the test to pass if the above wait timed out. (If it timed out that
// means the HTML never changed, which is a good thing.)
// TODO: Re-throw non-"condition never became true" errors to avoid false positives.
}
// This will fail if the above `waitForPromise()` succeeded.
helper.waitForPromise(() => helper.padInner$('body').html() === originalHTML);
});
it('does not insert unordered list', function (done) {