public-offering
/
pad.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PadMessageHandler: Avoid unnecessary property lookups

pull/5004/head
Richard Hansen 2021-04-12 23:22:36 -04:00
parent d5c6a44d9c
commit c85391862b
1 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/node/handler/PadMessageHandler.js
View File

@ -732,12 +732,11 @@ exports.updatePadClients = async (pad) => {
const revChangeset = revision.changeset;
const currentTime = revision.meta.timestamp;
// next if session has not been deleted
if (sessioninfos[sid] == null) {
continue;
}
// Re-check sessioninfos in case the client disconnected during the above await.
const sessioninfo = sessioninfos[sid];
if (sessioninfo == null) continue;
if (author === sessioninfos[sid].author) {
if (author === sessioninfo.author) {
socket.json.send({type: 'COLLABROOM', data: {type: 'ACCEPT_COMMIT', newRev: r}});
} else {
const forWire = Changeset.prepareForWire(revChangeset, pad.pool);
@ -748,15 +747,12 @@ exports.updatePadClients = async (pad) => {
apool: forWire.pool,
author,
currentTime,
timeDelta: currentTime - sessioninfos[sid].time}};
timeDelta: currentTime - sessioninfo.time}};
socket.json.send(wireMsg);
}
if (sessioninfos[sid]) {
sessioninfos[sid].time = currentTime;
sessioninfos[sid].rev = r;
}
sessioninfo.time = currentTime;
sessioninfo.rev = r;
}
}
};