From c39d0606cf45b66e6e4e6a684ba22767a5aff413 Mon Sep 17 00:00:00 2001
From: Richard Hansen <rhansen@rhansen.org>
Date: Sun, 7 Feb 2021 01:43:36 -0500
Subject: [PATCH] ace2_inner: Delete special arrow key handling

I can't see any reason this would be necessary, and it appears to not
behave as intended (`scroll.scrollWhenPressArrowKeys()` is not invoked
after a continuously held arrow key is finally let up).
---
 src/static/js/ace2_inner.js | 35 -----------------------------------
 1 file changed, 35 deletions(-)

diff --git a/src/static/js/ace2_inner.js b/src/static/js/ace2_inner.js
index a11c489b5..b41f4f0ff 100644
--- a/src/static/js/ace2_inner.js
+++ b/src/static/js/ace2_inner.js
@@ -3197,28 +3197,6 @@ function Ace2Inner() {
             scroll.setScrollY(caretOffsetTop);
           }, 200);
         }
-
-        // scroll to viewport when user presses arrow keys and caret is out of the viewport
-        if ((evt.which === 37 || evt.which === 38 || evt.which === 39 || evt.which === 40)) {
-          // we use arrowKeyWasReleased to avoid triggering the animation when a key
-          // is continuously pressed
-          // this makes the scroll smooth
-          if (!continuouslyPressingArrowKey(type)) {
-            // the caret position is not synchronized with the rep.
-            // For example, when an user presses arrow
-            // We use getSelection() instead of rep to get the caret position.
-            // This avoids errors like when down to scroll the pad without releasing the key.
-            // When the key is released the rep is not
-            // synchronized, so we don't get the right node where caret is.
-            const selection = getSelection();
-
-            if (selection) {
-              const arrowUp = evt.which === 38;
-              const innerHeight = getInnerHeight();
-              scroll.scrollWhenPressArrowKeys(arrowUp, rep, innerHeight);
-            }
-          }
-        }
       }
 
       if (type === 'keydown') {
@@ -3263,19 +3241,6 @@ function Ace2Inner() {
   };
 
   let thisKeyDoesntTriggerNormalize = false;
-  let arrowKeyWasReleased = true;
-  const continuouslyPressingArrowKey = (type) => {
-    let firstTimeKeyIsContinuouslyPressed = false;
-
-    if (type === 'keyup') {
-      arrowKeyWasReleased = true;
-    } else if (type === 'keydown' && arrowKeyWasReleased) {
-      firstTimeKeyIsContinuouslyPressed = true;
-      arrowKeyWasReleased = false;
-    }
-
-    return !firstTimeKeyIsContinuouslyPressed;
-  };
 
   const doUndoRedo = (which) => {
     // precond: normalized DOM