public-offering
/
pad.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

SocketIORouter: Rename variables to improve readability

pull/5171/head
Richard Hansen 2021-09-06 02:59:40 -04:00
parent 4a09000ca6
commit b9609a749d
1 changed files with 19 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
src/node/handler/SocketIORouter.js
View File

@ -21,9 +21,10 @@
*/ */
const log4js = require('log4js'); const log4js = require('log4js');
const messageLogger = log4js.getLogger('message');
const stats = require('../stats'); const stats = require('../stats');
const logger = log4js.getLogger('message');
/** /**
* Saves all components * Saves all components
* key is the component name * key is the component name
@ -31,7 +32,7 @@ const stats = require('../stats');
*/ */
const components = {}; const components = {};
let socket; let io;
/** /**
* adds a component * adds a component
@ -39,45 +40,42 @@ let socket;
exports.addComponent = (moduleName, module) => { exports.addComponent = (moduleName, module) => {
// save the component // save the component
components[moduleName] = module; components[moduleName] = module;
module.setSocketIO(io);
// give the module the socket
module.setSocketIO(socket);
}; };
/** /**
* sets the socket.io and adds event functions for routing * sets the socket.io and adds event functions for routing
*/ */
exports.setSocketIO = (_socket) => { exports.setSocketIO = (_io) => {
// save this socket internaly io = _io;
socket = _socket;
socket.sockets.on('connection', (client) => { io.sockets.on('connection', (socket) => {
// wrap the original send function to log the messages // wrap the original send function to log the messages
client._send = client.send; socket._send = socket.send;
client.send = (message) => { socket.send = (message) => {
messageLogger.debug(`to ${client.id}: ${JSON.stringify(message)}`); logger.debug(`to ${socket.id}: ${JSON.stringify(message)}`);
client._send(message); socket._send(message);
}; };
// tell all components about this connect // tell all components about this connect
for (const i of Object.keys(components)) { for (const i of Object.keys(components)) {
components[i].handleConnect(client); components[i].handleConnect(socket);
} }
client.on('message', async (message) => { socket.on('message', async (message) => {
if (message.protocolVersion && message.protocolVersion !== 2) { if (message.protocolVersion && message.protocolVersion !== 2) {
messageLogger.warn(`Protocolversion header is not correct: ${JSON.stringify(message)}`); logger.warn(`Protocolversion header is not correct: ${JSON.stringify(message)}`);
return; return;
} }
if (!message.component || !components[message.component]) { if (!message.component || !components[message.component]) {
messageLogger.error(`Can't route the message: ${JSON.stringify(message)}`); logger.error(`Can't route the message: ${JSON.stringify(message)}`);
return; return;
} }
messageLogger.debug(`from ${client.id}: ${JSON.stringify(message)}`); logger.debug(`from ${socket.id}: ${JSON.stringify(message)}`);
await components[message.component].handleMessage(client, message); await components[message.component].handleMessage(socket, message);
}); });
client.on('disconnect', () => { socket.on('disconnect', () => {
// store the lastDisconnect as a timestamp, this is useful if you want to know // store the lastDisconnect as a timestamp, this is useful if you want to know
// when the last user disconnected. If your activePads is 0 and totalUsers is 0 // when the last user disconnected. If your activePads is 0 and totalUsers is 0
// you can say, if there has been no active pads or active users for 10 minutes // you can say, if there has been no active pads or active users for 10 minutes
@ -85,7 +83,7 @@ exports.setSocketIO = (_socket) => {
stats.gauge('lastDisconnect', () => Date.now()); stats.gauge('lastDisconnect', () => Date.now());
// tell all components about this disconnect // tell all components about this disconnect
for (const i of Object.keys(components)) { for (const i of Object.keys(components)) {
components[i].handleDisconnect(client); components[i].handleDisconnect(socket);
} }
}); });
}); });