Merge pull request #2264 from prtksxna/a-span-title

Move `title` attribute of buttons from `<span>` to `<a>`
pull/2270/head
John McLear 2014-10-14 13:29:00 +01:00
commit b62c82575f
1 changed files with 4 additions and 4 deletions

View File

@ -99,8 +99,8 @@ _.extend(Button.prototype, {
"data-key": this.attributes.command, "data-key": this.attributes.command,
}; };
return tag("li", liAttributes, return tag("li", liAttributes,
tag("a", { "class": this.grouping }, tag("a", { "class": this.grouping, "data-l10n-id": this.attributes.localizationId },
tag("span", { "class": " "+ this.attributes.class, "data-l10n-id": this.attributes.localizationId }) tag("span", { "class": " "+ this.attributes.class })
) )
); );
} }
@ -203,13 +203,13 @@ module.exports = {
settings: defaultButtonAttributes("settings"), settings: defaultButtonAttributes("settings"),
embed: defaultButtonAttributes("embed"), embed: defaultButtonAttributes("embed"),
showusers: defaultButtonAttributes("showusers"), showusers: defaultButtonAttributes("showusers"),
timeslider_export: { timeslider_export: {
command: "import_export", command: "import_export",
localizationId: "timeslider.toolbar.exportlink.title", localizationId: "timeslider.toolbar.exportlink.title",
class: "buttonicon buttonicon-import_export" class: "buttonicon buttonicon-import_export"
}, },
timeslider_returnToPad: { timeslider_returnToPad: {
command: "timeslider_returnToPad", command: "timeslider_returnToPad",
localizationId: "timeslider.toolbar.returnbutton", localizationId: "timeslider.toolbar.returnbutton",