public-offering
/
pad.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gritter: Treat strings as text, not HTML 

This forces users to use jQuery or DOM objects if they want
formatting, which helps avoid XSS vulnerabilities.
pull/4425/head
Richard Hansen 2020-10-19 20:48:53 -04:00 committed by John McLear
parent 8463134125
commit a712ce457d
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/static/js/chat.js
View File

@ -193,7 +193,10 @@ var chat = (function()
if(!chatOpen && ctx.duration > 0) { if(!chatOpen && ctx.duration > 0) {
$.gritter.add({ $.gritter.add({
text: '<span class="author-name">' + ctx.authorName + '</span>' + ctx.text, // Note: ctx.authorName and ctx.text are already HTML-escaped.
text: $('<p>')
.append($('<span>').addClass('author-name').html(ctx.authorName))
.append(ctx.text),
sticky: ctx.sticky, sticky: ctx.sticky,
time: 5000, time: 5000,
position: 'bottom', position: 'bottom',

8
src/static/js/gritter.js
View File

@ -11,7 +11,8 @@
* Edited by Sebastian Castro <sebastian.castro@protonmail.com> on 2020-03-31 * Edited by Sebastian Castro <sebastian.castro@protonmail.com> on 2020-03-31
* *
* Edited by Richard Hansen <rhansen@rhansen.org> on 2020-10-19 to accept jQuery or DOM objects for * Edited by Richard Hansen <rhansen@rhansen.org> on 2020-10-19 to accept jQuery or DOM objects for
* notification title and text. * notification title and text, and to treat plain strings as text instead of HTML (to avoid XSS
* vunlerabilities).
*/ */
(function($){ (function($){
@ -142,7 +143,8 @@
// String replacements on the template // String replacements on the template
if(title){ if(title){
title = this._tpl_title.clone().append(title); title = this._tpl_title.clone().append(
typeof title === 'string' ? document.createTextNode(title) : title);
}else{ }else{
title = ''; title = '';
} }
@ -152,7 +154,7 @@
tmp.addClass(item_class); tmp.addClass(item_class);
tmp.find('.gritter-content') tmp.find('.gritter-content')
.append(title) .append(title)
.append(typeof text === 'string' ? $('<p>').html(text) : text); .append(typeof text === 'string' ? $('<p>').text(text) : text);
// If it's false, don't show another gritter message // If it's false, don't show another gritter message
if(this['_before_open_' + number]() === false){ if(this['_before_open_' + number]() === false){