public-offering
/
pad.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Docker: Abort image build when `npm install` fails (#4026) 

Without this change, plugin install failures are silently ignored.
pull/4008/head^2
Richard Hansen 2020-06-01 15:16:08 -04:00 committed by GitHub
parent 07c73d4f2d
commit a4713a8308
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Dockerfile
View File

@ -42,7 +42,7 @@ RUN bin/installDeps.sh && \
# #
# Bash trick: in the for loop ${ETHERPAD_PLUGINS} is NOT quoted, in order to be # Bash trick: in the for loop ${ETHERPAD_PLUGINS} is NOT quoted, in order to be
# able to split at spaces. # able to split at spaces.
RUN for PLUGIN_NAME in ${ETHERPAD_PLUGINS}; do npm install "${PLUGIN_NAME}"; done RUN for PLUGIN_NAME in ${ETHERPAD_PLUGINS}; do npm install "${PLUGIN_NAME}" || exit 1; done
# Copy the configuration file. # Copy the configuration file.
COPY --chown=etherpad:0 ./settings.json.docker /opt/etherpad-lite/settings.json COPY --chown=etherpad:0 ./settings.json.docker /opt/etherpad-lite/settings.json