diff --git a/Dockerfile b/Dockerfile index 6c45683f0..87e3b6f80 100644 --- a/Dockerfile +++ b/Dockerfile @@ -90,18 +90,8 @@ WORKDIR "${EP_DIR}" COPY --chown=etherpad:etherpad ./ ./ -# Plugins must be installed before installing Etherpad's dependencies, otherwise -# npm will try to hoist common dependencies by removing them from -# src/node_modules and installing them in the top-level node_modules. As of -# v6.14.10, npm's hoist logic appears to be buggy, because it sometimes removes -# dependencies from src/node_modules but fails to add them to the top-level -# node_modules. Even if npm correctly hoists the dependencies, the hoisting -# seems to confuse tools such as `npm outdated`, `npm update`, and some ESLint -# rules. -RUN { [ -z "${ETHERPAD_PLUGINS}" ] || \ - npm install --no-save --legacy-peer-deps ${ETHERPAD_PLUGINS}; } && \ - src/bin/installDeps.sh && \ - rm -rf ~/.npm +RUN { [ -z "${ETHERPAD_PLUGINS}" ] || /bin/bash -c 'ARR_PLUGINS=($ETHERPAD_PLUGINS) && jq -n "{plugins: \$ARGS.positional}" --args ${ARR_PLUGINS[@]} > var/installed_plugins.json'; } && \ + src/bin/installDeps.sh && # Copy the configuration file. COPY --chown=etherpad:etherpad ${SETTINGS} "${EP_DIR}"/settings.json diff --git a/src/static/js/pluginfw/installer.js b/src/static/js/pluginfw/installer.js index 060b1d897..b7e42b345 100644 --- a/src/static/js/pluginfw/installer.js +++ b/src/static/js/pluginfw/installer.js @@ -65,7 +65,9 @@ exports.checkForMigration = async () => { const installedPlugins = JSON.parse(fileContent.toString()); for (const plugin of installedPlugins.plugins) { - await exports.manager.install(plugin) + if (plugin.startsWith(plugins.prefix) && plugin !== 'ep_etherpad-lite') { + await exports.manager.install(plugin) + } } };