public-offering
/
pad.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PadMessageHandler: Don't fill in default name or color 

It should be the client's responsibility to handle null name or color.
In the case of author names, passing null to the client allows users
to fill in the names of other users (via a suggestUserName
CLIENT_MESSAGE).
pull/4521/head
Richard Hansen 2020-11-26 00:34:08 -05:00 committed by John McLear
parent ef7ae15722
commit 98066184b2
1 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/node/handler/PadMessageHandler.js
View File

@ -1140,23 +1140,6 @@ async function handleClientReady(socket, message, authorID) {
return; return;
} }
// default fallback color to use if authorInfo.colorId is null
const defaultColor = '#daf0b2';
// For some reason sometimes name isn't set
// Catch this issue here and use a fixed name.
if (!authorInfo.name) {
console.warn('handleClientReady(): client submitted no author name. Using "Anonymous". See: issue #3612');
authorInfo.name = 'Anonymous';
}
// For some reason sometimes colorId isn't set
// Catch this issue here and use a fixed color.
if (!authorInfo.colorId) {
console.warn(`handleClientReady(): author "${authorInfo.name}" has no property colorId. Using the default color ${defaultColor}. See issue #3612`);
authorInfo.colorId = defaultColor;
}
// Send the new User a Notification about this other user // Send the new User a Notification about this other user
const msg = { const msg = {
type: 'COLLABROOM', type: 'COLLABROOM',