public-offering
/
pad.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

LibreOffice: Close stdin right away 

This should prevent LibreOffice from hanging if it attempts to read
from stdin (it'll get EOF and probably exit with an error instead).
pull/5208/head
Richard Hansen 2021-09-29 21:33:46 -04:00
parent 0c31940b09
commit 76374bc489
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/node/utils/LibreOffice.js
View File

@ -44,10 +44,11 @@ const doConvertTask = async (task) => {
'--outdir', '--outdir',
tmpDir, tmpDir,
]); ]);
soffice.stdin.end();
// Soffice/libreoffice is buggy and often hangs. // Soffice/libreoffice is buggy and often hangs.
// To remedy this we kill the spawned process after a while. // To remedy this we kill the spawned process after a while.
// TODO: Use the timeout option once support for Node.js < v15.13.0 is dropped.
const hangTimeout = setTimeout(() => { const hangTimeout = setTimeout(() => {
soffice.stdin.pause(); // required to kill hanging threads
soffice.kill(); soffice.kill();
}, 120000); }, 120000);
let stdoutBuffer = ''; let stdoutBuffer = '';