From 57d0a2e803d8efd2721c575e225bc9d90910d6d3 Mon Sep 17 00:00:00 2001
From: Chad Weider <cweider@oofn.net>
Date: Sun, 4 Mar 2012 15:04:54 -0800
Subject: [PATCH 1/3] Avoid orphaned cache files from breaking the caching
 layer.

---
 node/utils/caching_middleware.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/node/utils/caching_middleware.js b/node/utils/caching_middleware.js
index f25059b88..d99023e09 100644
--- a/node/utils/caching_middleware.js
+++ b/node/utils/caching_middleware.js
@@ -54,7 +54,7 @@ CachingMiddleware.prototype = new function () {
       var modifiedSince = (req.headers['if-modified-since']
           && new Date(req.headers['if-modified-since']));
       var lastModifiedCache = !error && stats.mtime;
-      if (lastModifiedCache) {
+      if (lastModifiedCache && responseCache[cacheKey]) {
         req.headers['if-modified-since'] = lastModifiedCache.toUTCString();
       } else {
         delete req.headers['if-modified-since'];

From 0930b64c4e1c8aa1eccac533fc8fbd2605ccf33f Mon Sep 17 00:00:00 2001
From: Chad Weider <cweider@oofn.net>
Date: Sun, 4 Mar 2012 15:05:22 -0800
Subject: [PATCH 2/3] Handle Windows paths correctly (again).

---
 node/utils/Minify.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/node/utils/Minify.js b/node/utils/Minify.js
index a49195a7b..39c6ceb3f 100644
--- a/node/utils/Minify.js
+++ b/node/utils/Minify.js
@@ -149,8 +149,10 @@ function getAceFile(callback) {
       var request = require('request');
 
       var baseURI = 'http://localhost:' + settings.port
+      var resourceURI = baseURI + path.normalize(path.join('/static/', filename));
+      resourceURI = resourceURI.replace(/\\/g, '/'); // Windows (safe generally?)
 
-      request(baseURI + path.normalize(path.join('/static/', filename)), function (error, response, body) {
+      request(resourceURI, function (error, response, body) {
         if (!error && response.statusCode == 200) {
           data += 'Ace2Editor.EMBEDED[' + JSON.stringify(filename) + '] = '
               + JSON.stringify(body || '') + ';\n';

From 29548244fdcc905da082f208656d61206c518dbf Mon Sep 17 00:00:00 2001
From: Chad Weider <cweider@oofn.net>
Date: Sun, 4 Mar 2012 15:13:15 -0800
Subject: [PATCH 3/3] Do not cache 404 responses.

This makes DOS attacks way to easy. This really needs to be replaced with an LRU (e.g. a prebuilt middleware).
---
 node/utils/caching_middleware.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/node/utils/caching_middleware.js b/node/utils/caching_middleware.js
index d99023e09..a26e22d18 100644
--- a/node/utils/caching_middleware.js
+++ b/node/utils/caching_middleware.js
@@ -83,7 +83,7 @@ CachingMiddleware.prototype = new function () {
             && new Date(res.getHeader('last-modified')));
 
         res.writeHead = old_res.writeHead;
-        if (status == 200 || status == 404) {
+        if (status == 200) {
           // Update cache
           var buffer = '';