public-offering
/
pad.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't try to populate padlist on each req 

This is an important fix, prolly wants merging into master ASAP.  

Before this fix each new pad request would re-populate the all pads object, this is a blocking procedure and slows down the loading to a point where it's almost useless :(

Testing didn't find this because our testing stack isn't populated with pad data :|  TLDR.  Our tests still suck, hard.
pull/1939/head
John McLear 2013-10-13 16:39:45 +01:00
parent 8c9e543b91
commit 680d9a2811
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/node/db/PadManager.js
View File

@ -38,7 +38,7 @@ var globalPads = {
{ {
this[':'+name] = value; this[':'+name] = value;
if(!padList.list.length == 0){ // If we haven't populated the padList.list yet if(padList.list.length == 0){ // If we haven't populated the padList.list yet
padList.init(); padList.init();
} }
@ -163,7 +163,7 @@ exports.getPad = function(id, text, callback)
exports.listAllPads = function(callback) exports.listAllPads = function(callback)
{ {
if(!padList.list.length == 0){ // If we haven't populated the padList.list yet if(padList.list.length == 0){ // If we haven't populated the padList.list yet
padList.init(); padList.init();
} }
if(callback != null){ if(callback != null){
@ -231,7 +231,7 @@ exports.isValidPadId = function(padId)
* Removes the pad from database and unloads it. * Removes the pad from database and unloads it.
*/ */
exports.removePad = function(padId){ exports.removePad = function(padId){
if(!padList.list.length == 0){ // If we haven't populated the padList.list yet if(padList.list.length == 0){ // If we haven't populated the padList.list yet
padList.init(); padList.init();
} }
db.remove("pad:"+padId); db.remove("pad:"+padId);