public-offering
/
pad.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hooks: Inline `syncMapFirst()` into `callFirst()` for readability 

There's only one caller of the function, and the function is simple,
so there's no need for a separate function.
pull/4698/head
Richard Hansen 2021-01-31 18:35:17 -05:00 committed by John McLear
parent 53ccfa8703
commit 4ab7a99512
1 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/static/js/pluginfw/hooks.js
View File

@ -40,15 +40,6 @@ const hookCallWrapper = (hook, hookName, context, cb) => {
return () => normalize(hook.hook_fn(hookName, context, (x) => cb(normalize(x)))); return () => normalize(hook.hook_fn(hookName, context, (x) => cb(normalize(x))));
}; };
const syncMapFirst = (hooks, fn) => {
const predicate = (val) => val.length;
for (const hook of hooks) {
const val = fn(hook);
if (predicate(val)) return val;
}
return [];
};
const mapFirst = async (hooks, fn, predicate = null) => { const mapFirst = async (hooks, fn, predicate = null) => {
if (predicate == null) predicate = (val) => val.length; if (predicate == null) predicate = (val) => val.length;
for (const hook of hooks) { for (const hook of hooks) {
@ -364,9 +355,13 @@ exports.aCallAll = async (hookName, context, cb) => {
exports.callFirst = (hookName, context) => { exports.callFirst = (hookName, context) => {
if (!context) context = {}; if (!context) context = {};
if (pluginDefs.hooks[hookName] === undefined) return []; const predicate = (val) => val.length;
return syncMapFirst(pluginDefs.hooks[hookName], const hooks = pluginDefs.hooks[hookName] || [];
(hook) => hookCallWrapper(hook, hookName, context)); for (const hook of hooks) {
const val = hookCallWrapper(hook, hookName, context);
if (predicate(val)) return val;
}
return [];
}; };
const aCallFirst = (hookName, context, cb, predicate) => { const aCallFirst = (hookName, context, cb, predicate) => {