Move `title` attribute of buttons from `<span>` to `<a>`
The `.toolbar ul li a` that holds the `span.button` has a padding of `4px 5px`. This means if the mouse is on the edge of the button the `:hover` state is active but the relevant tooltip does not show up. Moving the `title` attribute to the `<a>` itself solves this problem. Also removed some extra whitespace.pull/2264/head
parent
6ec55309a7
commit
437b2bfc64
|
@ -99,8 +99,8 @@ _.extend(Button.prototype, {
|
||||||
"data-key": this.attributes.command,
|
"data-key": this.attributes.command,
|
||||||
};
|
};
|
||||||
return tag("li", liAttributes,
|
return tag("li", liAttributes,
|
||||||
tag("a", { "class": this.grouping },
|
tag("a", { "class": this.grouping, "data-l10n-id": this.attributes.localizationId },
|
||||||
tag("span", { "class": " "+ this.attributes.class, "data-l10n-id": this.attributes.localizationId })
|
tag("span", { "class": " "+ this.attributes.class })
|
||||||
)
|
)
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue