From 42026ff7717c15aecaa8ccb46fd31f45ddb49fb3 Mon Sep 17 00:00:00 2001 From: Richard Hansen Date: Thu, 22 Jul 2021 13:30:28 -0400 Subject: [PATCH] tests: Add a comment explaining why `Promise.all()` is not used --- src/tests/frontend/helper.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/tests/frontend/helper.js b/src/tests/frontend/helper.js index 1f1cc3e71..cf8cdcee6 100644 --- a/src/tests/frontend/helper.js +++ b/src/tests/frontend/helper.js @@ -37,6 +37,8 @@ const helper = {}; }; if (!win.$) await load('../../static/js/vendors/jquery.js'); + // sendkeys.js depends on jQuery, so it cannot be loaded until jQuery has finished loading. (In + // other words, do not load both jQuery and sendkeys inside a Promise.all() call.) if (!win.bililiteRange && includeSendkeys) await load('../tests/frontend/lib/sendkeys.js'); win.$.window = win;