From 3eefe7183410a07b764492c9ac36ff866f634fde Mon Sep 17 00:00:00 2001 From: Richard Hansen Date: Thu, 11 Feb 2021 19:16:55 -0500 Subject: [PATCH] Minify: Don't set cache headers if `statFile()` causes 500 --- src/node/utils/Minify.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/node/utils/Minify.js b/src/node/utils/Minify.js index eb6171ca2..2c3fb7c1f 100644 --- a/src/node/utils/Minify.js +++ b/src/node/utils/Minify.js @@ -146,6 +146,11 @@ const minify = (req, res) => { const contentType = mime.lookup(filename); util.callbackify(statFile)(filename, 3, (error, [date, exists]) => { + if (error) { + res.writeHead(500, {}); + res.end(); + return; + } if (date) { date = new Date(date); date.setMilliseconds(0); @@ -158,10 +163,7 @@ const minify = (req, res) => { } } - if (error) { - res.writeHead(500, {}); - res.end(); - } else if (!exists) { + if (!exists) { res.writeHead(404, {}); res.end(); } else if (new Date(req.headers['if-modified-since']) >= date) {