public-offering
/
pad.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

collab_client: Delete unused `caughtErrors`

pull/4986/head
Richard Hansen 2021-03-26 19:46:46 -04:00
parent 81b9a2544d
commit 3ee6b5eb2b
1 changed files with 8 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
src/static/js/collab_client.js
View File

@ -50,9 +50,6 @@ const getCollabClient = (ace2editor, serverVars, initialUserInfo, options, _pad)
const userSet = {}; // userId -> userInfo
userSet[userId] = initialUserInfo;
const caughtErrors = [];
const caughtErrorCatchers = [];
const caughtErrorTimes = [];
const msgQueue = [];
let isPendingRevision = false;
@ -84,7 +81,7 @@ const getCollabClient = (ace2editor, serverVars, initialUserInfo, options, _pad)
setChannelState('DISCONNECTED', 'initsocketfail');
} else {
// check again in a bit
setTimeout(wrapRecordingErrors('setTimeout(handleUserChanges)', handleUserChanges), 1000);
setTimeout(handleUserChanges, 1000);
}
return;
}
@ -99,16 +96,14 @@ const getCollabClient = (ace2editor, serverVars, initialUserInfo, options, _pad)
callbacks.onConnectionTrouble('SLOW');
} else {
// run again in a few seconds, to detect a disconnect
setTimeout(wrapRecordingErrors('setTimeout(handleUserChanges)', handleUserChanges), 3000);
setTimeout(handleUserChanges, 3000);
}
return;
}
const earliestCommit = lastCommitTime + 500;
if (t < earliestCommit) {
setTimeout(
wrapRecordingErrors('setTimeout(handleUserChanges)', handleUserChanges),
earliestCommit - t);
setTimeout(handleUserChanges, earliestCommit - t);
return;
}
@ -153,24 +148,22 @@ const getCollabClient = (ace2editor, serverVars, initialUserInfo, options, _pad)
}
} else {
// run again in a few seconds, to check if there was a reconnection attempt
setTimeout(wrapRecordingErrors('setTimeout(handleUserChanges)', handleUserChanges), 3000);
setTimeout(handleUserChanges, 3000);
}
if (sentMessage) {
// run again in a few seconds, to detect a disconnect
setTimeout(wrapRecordingErrors('setTimeout(handleUserChanges)', handleUserChanges), 3000);
setTimeout(handleUserChanges, 3000);
}
};
const acceptCommit = () => {
editor.applyPreparedChangesetToBase();
setStateIdle();
callCatchingErrors('onInternalAction', () => {
try {
callbacks.onInternalAction('commitAcceptedByServer');
});
callCatchingErrors('onConnectionTrouble', () => {
callbacks.onConnectionTrouble('OK');
});
} catch (err) { /* intentionally ignored */ }
handleUserChanges();
};
@ -190,25 +183,6 @@ const getCollabClient = (ace2editor, serverVars, initialUserInfo, options, _pad)
});
};
const wrapRecordingErrors = (catcher, func) => function (...args) {
try {
return func.call(this, ...args);
} catch (e) {
caughtErrors.push(e);
caughtErrorCatchers.push(catcher);
caughtErrorTimes.push(+new Date());
// console.dir({catcher: catcher, e: e});
throw e;
}
};
const callCatchingErrors = (catcher, func) => {
try {
wrapRecordingErrors(catcher, func)();
} catch (e) { /* absorb*/
}
};
const handleMessageFromServer = (evt) => {
if (!getSocket()) return;
if (!evt.data) return;
@ -566,8 +540,7 @@ const getCollabClient = (ace2editor, serverVars, initialUserInfo, options, _pad)
editor.setProperty('userAuthor', userId);
editor.setBaseAttributedText(serverVars.initialAttributedText, serverVars.apool);
editor.setUserChangeNotificationCallback(
wrapRecordingErrors('handleUserChanges', handleUserChanges));
editor.setUserChangeNotificationCallback(handleUserChanges);
setUpSocket();
return self;