From 3667f2ca0ed91f010f4c39aad26fba780189b5d4 Mon Sep 17 00:00:00 2001 From: Richard Hansen Date: Sun, 28 Feb 2021 00:15:28 -0500 Subject: [PATCH] Ace2Inner: Fix missing spread operator on `args` This fixes a bug that was introduced in commit c38c34bef47a74467394797b34165641a87ac620. --- CHANGELOG.md | 2 ++ src/static/js/ace2_inner.js | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 494545892..331a1b98e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,8 @@ * Fixed a bug in the `dirty` database driver that sometimes caused Node.js to crash during shutdown and lose buffered database writes. +* Fixed a regression in v1.8.8 that caused "Uncaught TypeError: Cannot read + property '0' of undefined" with some plugins (#4885) # 1.8.11 diff --git a/src/static/js/ace2_inner.js b/src/static/js/ace2_inner.js index 4858aa1b4..5ae4f0660 100644 --- a/src/static/js/ace2_inner.js +++ b/src/static/js/ace2_inner.js @@ -3894,7 +3894,7 @@ function Ace2Inner() { documentAttributeManager = new AttributeManager(rep, performDocumentApplyChangeset); editorInfo.ace_performDocumentApplyAttributesToRange = - (...args) => documentAttributeManager.setAttributesOnRange(args); + (...args) => documentAttributeManager.setAttributesOnRange(...args); this.init = () => { $(document).ready(() => {