public-offering
/
pad.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

plugins: add peerdeps and correct engine to checkPlugins script (#4524) 

* pere deps example

* fixed by rh

* doh

* doh...
plugins-hanging
John McLear 2020-11-27 21:43:23 +00:00 committed by GitHub
parent 5fcf5f6135
commit 325941a1ad
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 23 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
bin/plugins/checkPlugin.js
View File

@ -165,6 +165,26 @@ fs.readdir(pluginPath, (err, rootFiles) => {
} }
} }
// include peer deps config
if (packageJSON.toLowerCase().indexOf('peerdependencies') === -1 || !parsedPackageJSON.peerDependencies) {
console.warn('Missing peer deps reference in package.json');
if (autoFix) {
const peerDependencies = {
"ep_etherpad-lite": ">=1.8.6",
}
hasAutoFixed = true;
parsedPackageJSON.peerDependencies = peerDependencies;
fs.writeFileSync(`${pluginPath}/package.json`, JSON.stringify(parsedPackageJSON, null, 2));
const child_process = require('child_process');
try {
child_process.execSync('npm install --no-save ep_etherpad-lite@file:../../src', {cwd: `${pluginPath}/`});
hasAutoFixed = true;
} catch (e) {
console.error('Failed to create package-lock.json');
}
}
}
if (packageJSON.toLowerCase().indexOf('eslintconfig') === -1) { if (packageJSON.toLowerCase().indexOf('eslintconfig') === -1) {
console.warn('No esLintConfig in package.json'); console.warn('No esLintConfig in package.json');
if (autoFix) { if (autoFix) {
@ -191,11 +211,11 @@ fs.readdir(pluginPath, (err, rootFiles) => {
} }
} }
if (packageJSON.toLowerCase().indexOf('engines') === -1) { if ( (packageJSON.toLowerCase().indexOf('engines') === -1) || !parsedPackageJSON.engines.node) {
console.warn('No engines in package.json'); console.warn('No engines or node engine in package.json');
if (autoFix) { if (autoFix) {
const engines = { const engines = {
lint: 'eslint .', node: '>=10.13.0',
}; };
hasAutoFixed = true; hasAutoFixed = true;
parsedPackageJSON.engines = engines; parsedPackageJSON.engines = engines;