From 1fc5519c86dd95136471149e0ae99a4c0c5ca4e2 Mon Sep 17 00:00:00 2001
From: 0ip <me@factor.cc>
Date: Tue, 4 Dec 2012 14:30:30 +0100
Subject: [PATCH 1/2] Display plugin versions

---
 src/static/js/admin/plugins.js   | 4 ++++
 src/templates/admin/plugins.html | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/src/static/js/admin/plugins.js b/src/static/js/admin/plugins.js
index 93acf6ea5..a279498f4 100644
--- a/src/static/js/admin/plugins.js
+++ b/src/static/js/admin/plugins.js
@@ -113,10 +113,14 @@ $(document).ready(function () {
     for (plugin_name in data.results) {
       var plugin = data.results[plugin_name];
       var row = widget.find(".template tr").clone();
+      var version = '0.0.0';
+      for (version in data.results[plugin_name].versions) break;
 
       for (attr in plugin) {
         row.find("." + attr).html(plugin[attr]);
       }
+      row.find(".version").html(version);
+      
       widget.find(".results").append(row);
     }
 
diff --git a/src/templates/admin/plugins.html b/src/templates/admin/plugins.html
index 3dad3bd01..394cf0e06 100644
--- a/src/templates/admin/plugins.html
+++ b/src/templates/admin/plugins.html
@@ -30,6 +30,7 @@
           <tr>
             <th>Name</th>
             <th>Description</th>
+            <th>Version</th>
             <td></td>
           </tr>
         </thead>
@@ -37,6 +38,7 @@
           <tr id="installed-plugin-template">
             <td class="name"></td>
             <td class="description"></td>
+              <td class="version"></td>
             <td class="actions">
               <input type="button" value="Uninstall" class="do-uninstall">
             </td>
@@ -58,6 +60,7 @@
             <tr>
               <th>Name</th>
               <th>Description</th>
+              <th>Version</th>
               <td></td>
             </tr>
           </thead>
@@ -65,6 +68,7 @@
             <tr>
               <td class="name"></td>
               <td class="description"></td>
+              <td class="version"></td>
               <td class="actions">
                 <input type="button" value="Install" class="do-install">
              </td>

From 20f13bc8cedb3721d64af6da9214df150959218c Mon Sep 17 00:00:00 2001
From: 0ip <me@factor.cc>
Date: Tue, 4 Dec 2012 19:08:25 +0100
Subject: [PATCH 2/2] Add comment to explain how the property containing the
 version is being read

---
 src/static/js/admin/plugins.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/static/js/admin/plugins.js b/src/static/js/admin/plugins.js
index a279498f4..618520282 100644
--- a/src/static/js/admin/plugins.js
+++ b/src/static/js/admin/plugins.js
@@ -114,6 +114,7 @@ $(document).ready(function () {
       var plugin = data.results[plugin_name];
       var row = widget.find(".template tr").clone();
       var version = '0.0.0';
+      // hack to access "versions" property of the npm package object
       for (version in data.results[plugin_name].versions) break;
 
       for (attr in plugin) {