public-offering
/
pad.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PadMessageHandler: Plumb author ID to more pad creation locations

pull/5433/head
Richard Hansen 2022-02-23 13:41:26 -05:00
parent 363a48b6d5
commit 2d53b9f150
2 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/node/handler/ImportHandler.js
View File

@ -185,8 +185,8 @@ const doImport = async (req, res, padId, authorId) => {
} }
} }
// get the pad object // Use '\n' to avoid the default pad text if the pad doesn't yet exist.
let pad = await padManager.getPad(padId); let pad = await padManager.getPad(padId, '\n', authorId);
// read the text // read the text
let text; let text;
@ -216,7 +216,7 @@ const doImport = async (req, res, padId, authorId) => {
// Load the Pad into memory then broadcast updates to all clients // Load the Pad into memory then broadcast updates to all clients
padManager.unloadPad(padId); padManager.unloadPad(padId);
pad = await padManager.getPad(padId); pad = await padManager.getPad(padId, '\n', authorId);
padManager.unloadPad(padId); padManager.unloadPad(padId);
// Direct database access means a pad user should reload the pad and not attempt to receive // Direct database access means a pad user should reload the pad and not attempt to receive

16
src/node/handler/PadMessageHandler.js
View File

@ -372,7 +372,7 @@ exports.handleMessage = async (socket, message) => {
*/ */
const handleSaveRevisionMessage = async (socket, message) => { const handleSaveRevisionMessage = async (socket, message) => {
const {padId, author: authorId} = sessioninfos[socket.id]; const {padId, author: authorId} = sessioninfos[socket.id];
const pad = await padManager.getPad(padId); const pad = await padManager.getPad(padId, null, authorId);
await pad.addSavedRevision(pad.head, authorId); await pad.addSavedRevision(pad.head, authorId);
}; };
@ -441,7 +441,7 @@ const handleChatMessage = async (socket, message) => {
exports.sendChatMessageToPadClients = async (mt, puId, text = null, padId = null) => { exports.sendChatMessageToPadClients = async (mt, puId, text = null, padId = null) => {
const message = mt instanceof ChatMessage ? mt : new ChatMessage(text, puId, mt); const message = mt instanceof ChatMessage ? mt : new ChatMessage(text, puId, mt);
padId = mt instanceof ChatMessage ? puId : padId; padId = mt instanceof ChatMessage ? puId : padId;
const pad = await padManager.getPad(padId); const pad = await padManager.getPad(padId, null, message.authorId);
await hooks.aCallAll('chatNewMessage', {message, pad, padId}); await hooks.aCallAll('chatNewMessage', {message, pad, padId});
// pad.appendChatMessage() ignores the displayName property so we don't need to wait for // pad.appendChatMessage() ignores the displayName property so we don't need to wait for
// authorManager.getAuthorName() to resolve before saving the message to the database. // authorManager.getAuthorName() to resolve before saving the message to the database.
@ -464,8 +464,8 @@ const handleGetChatMessages = async (socket, {data: {start, end}}) => {
if (!Number.isInteger(end)) throw new Error(`missing or invalid end: ${end}`); if (!Number.isInteger(end)) throw new Error(`missing or invalid end: ${end}`);
const count = end - start; const count = end - start;
if (count < 0 || count > 100) throw new Error(`invalid number of messages: ${count}`); if (count < 0 || count > 100) throw new Error(`invalid number of messages: ${count}`);
const padId = sessioninfos[socket.id].padId; const {padId, author: authorId} = sessioninfos[socket.id];
const pad = await padManager.getPad(padId); const pad = await padManager.getPad(padId, null, authorId);
const chatMessages = await pad.getChatMessages(start, end); const chatMessages = await pad.getChatMessages(start, end);
const infoMsg = { const infoMsg = {
@ -574,7 +574,7 @@ const handleUserChanges = async (socket, message) => {
if (apool == null) throw new Error('missing apool'); if (apool == null) throw new Error('missing apool');
if (changeset == null) throw new Error('missing changeset'); if (changeset == null) throw new Error('missing changeset');
const wireApool = (new AttributePool()).fromJsonable(apool); const wireApool = (new AttributePool()).fromJsonable(apool);
const pad = await padManager.getPad(thisSession.padId); const pad = await padManager.getPad(thisSession.padId, null, thisSession.author);
// Verify that the changeset has valid syntax and is in canonical form // Verify that the changeset has valid syntax and is in canonical form
Changeset.checkRep(changeset); Changeset.checkRep(changeset);
@ -790,7 +790,7 @@ const handleClientReady = async (socket, message) => {
({colorId: authorColorId, name: authorName} = await authorManager.getAuthor(sessionInfo.author)); ({colorId: authorColorId, name: authorName} = await authorManager.getAuthor(sessionInfo.author));
// load the pad-object from the database // load the pad-object from the database
const pad = await padManager.getPad(sessionInfo.padId); const pad = await padManager.getPad(sessionInfo.padId, null, sessionInfo.author);
// these db requests all need the pad object (timestamp of latest revision, author data) // these db requests all need the pad object (timestamp of latest revision, author data)
const authors = pad.getAllAuthors(); const authors = pad.getAllAuthors();
@ -1078,8 +1078,8 @@ const handleChangesetRequest = async (socket, {data: {granularity, start, reques
if (start == null) throw new Error('missing start'); if (start == null) throw new Error('missing start');
if (requestID == null) throw new Error('mising requestID'); if (requestID == null) throw new Error('mising requestID');
const end = start + (100 * granularity); const end = start + (100 * granularity);
const {padId} = sessioninfos[socket.id]; const {padId, author: authorId} = sessioninfos[socket.id];
const pad = await padManager.getPad(padId); const pad = await padManager.getPad(padId, null, authorId);
const data = await getChangesetInfo(pad, start, end, granularity); const data = await getChangesetInfo(pad, start, end, granularity);
data.requestID = requestID; data.requestID = requestID;
socket.json.send({type: 'CHANGESET_REQ', data}); socket.json.send({type: 'CHANGESET_REQ', data});