public-offering
/
pad.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

db/Pad.js: make "force" parameter non optional in Pad.prototype.copy() 

This function was simulating two overloads:
  1. copy(destinationID, force, callback)
  2. copy(destinationID, callback), in this case "force" would be assumed false

But all the call sites always used the version with arity 3.
Thus, we can remove that optionality and always assume that the funcion will be
called with three parameters. This will simplify future work.
pull/3572/head
muxator 2019-02-13 14:01:24 +01:00
parent 1900b00ec2
commit 26f3f1bcd0
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/node/db/Pad.js
View File

@ -454,15 +454,12 @@ Pad.prototype.copy = function copy(destinationID, force, callback) {
var _this = this;
var destGroupID;
// make force optional
if (typeof force == "function") {
callback = force;
force = false;
// allow force to be a string
if (typeof force === "string") {
force = (force.toLowerCase() === "true");
} else {
force = !!force;
}
else if (force == undefined || force.toLowerCase() != "true") {
force = false;
}
else force = true;
// Kick everyone from this pad.
// This was commented due to https://github.com/ether/etherpad-lite/issues/3183.