public-offering
/
pad.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

API: fix createGroup for mapper endpoint for cases when a mapped group has been deleted 

fixes #1890
pull/1893/head
Marcel Klehr 2013-09-18 16:04:10 +02:00
parent 4bf3f7ab12
commit 182ce5c48d
1 changed files with 17 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/node/db/GroupManager.js
View File

@ -215,25 +215,32 @@ exports.createGroupIfNotExistsFor = function(groupMapper, callback)
{ {
if(ERR(err, callback)) return; if(ERR(err, callback)) return;
// there is a group for this mapper
if(groupID) {
exports.doesGroupExist(groupID, function(err, exists) {
if(ERR(err, callback)) return;
if(exists) return callback(null, {groupID: groupID});
// hah, the returned group doesn't exist, let's create one
createGroupForMapper(callback)
})
}
//there is no group for this mapper, let's create a group //there is no group for this mapper, let's create a group
if(groupID == null) else {
{ createGroupForMapper(callback)
}
function createGroupForMapper(cb) {
exports.createGroup(function(err, responseObj) exports.createGroup(function(err, responseObj)
{ {
if(ERR(err, callback)) return; if(ERR(err, cb)) return;
//create the mapper entry for this group //create the mapper entry for this group
db.set("mapper2group:"+groupMapper, responseObj.groupID); db.set("mapper2group:"+groupMapper, responseObj.groupID);
callback(null, responseObj); cb(null, responseObj);
}); });
} }
//there is a group for this mapper, let's return it
else
{
if(ERR(err, callback)) return;
callback(null, {groupID: groupID});
}
}); });
} }