public-offering
/
pad.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PadMessageHandler: Improve readability of historical author fetch

pull/5255/head
Richard Hansen 2021-10-30 00:46:05 -04:00
parent d36a37d666
commit 0992f19570
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/node/handler/PadMessageHandler.js
View File

@ -833,7 +833,8 @@ const handleClientReady = async (socket, message, authorID) => {
// get all author data out of the database (in parallel) // get all author data out of the database (in parallel)
const historicalAuthorData = {}; const historicalAuthorData = {};
await Promise.all(authors.map((authorId) => authorManager.getAuthor(authorId).then((author) => { await Promise.all(authors.map(async (authorId) => {
const author = await authorManager.getAuthor(authorId);
if (!author) { if (!author) {
messageLogger.error(`There is no author for authorId: ${authorId}. ` + messageLogger.error(`There is no author for authorId: ${authorId}. ` +
'This is possibly related to https://github.com/ether/etherpad-lite/issues/2802'); 'This is possibly related to https://github.com/ether/etherpad-lite/issues/2802');
@ -841,7 +842,7 @@ const handleClientReady = async (socket, message, authorID) => {
// Filter author attribs (e.g. don't send author's pads to all clients) // Filter author attribs (e.g. don't send author's pads to all clients)
historicalAuthorData[authorId] = {name: author.name, colorId: author.colorId}; historicalAuthorData[authorId] = {name: author.name, colorId: author.colorId};
} }
}))); }));
// glue the clientVars together, send them and tell the other clients that a new one is there // glue the clientVars together, send them and tell the other clients that a new one is there