public-offering
/
cal.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
cal.pub0.org/packages/embeds/embed-react
History
Hariom Balhara a0bf5b4067
test: Smoke Tests for packaged embeds and build improvements (#9169) 
* Fix 2 Factor Auth

* Add a sandbox to verify types of embed-react

* Add fault types location

* Fix type location again

* Break types

* Ensure that builds are done again when doing pbublish

* Debug failure in CI

* Make sure unit test files arent used by playwright

* Fix embed-react test description

* Update .github/workflows/e2e-embed-react.yml

Co-authored-by: Omar López <zomars@me.com>

* Remove unnecessary log

---------

Co-authored-by: Alex van Andel <me@alexvanandel.com>
Co-authored-by: Omar López <zomars@me.com>
 		2023-06-01 20:41:30 +00:00
..
playwright/tests test: Smoke Tests for packaged embeds and build improvements (#9169) 2023-06-01 20:41:30 +00:00
src test: Smoke Tests for packaged embeds and build improvements (#9169) 2023-06-01 20:41:30 +00:00
test/packaged test: Smoke Tests for packaged embeds and build improvements (#9169) 2023-06-01 20:41:30 +00:00
.gitignore Embed Miscellaneous Improvements and Fixes (#2499) 2022-04-25 10:03:00 +05:30
CHANGELOG.md fix: location for `@calcom/embed-react` types (#9090) 2023-05-29 20:30:52 -07:00
LICENSE change /ee to /commercial (#8948) 2023-05-25 17:50:30 +00:00
README.md feat: trpc v10 migration (#5332) 2022-11-10 23:40:01 +00:00
env.d.ts Fix @calcom/embed-react installation with TS project (#2870) 2022-05-27 09:37:02 -06:00
floating.html Embed: Strictly type the codebase and fixes a few bugs found (#7536) 2023-03-28 11:17:40 -07:00
floating.tsx Embed: Strictly type the codebase and fixes a few bugs found (#7536) 2023-03-28 11:17:40 -07:00
index.html Embed: Strictly type the codebase and fixes a few bugs found (#7536) 2023-03-28 11:17:40 -07:00
inline.tsx test: Smoke Tests for packaged embeds and build improvements (#9169) 2023-06-01 20:41:30 +00:00
package.json test: Smoke Tests for packaged embeds and build improvements (#9169) 2023-06-01 20:41:30 +00:00
tsconfig.json test: Smoke Tests for packaged embeds and build improvements (#9169) 2023-06-01 20:41:30 +00:00
vite.config.js Fix @calcom/embed-react installation with TS project (#2870) 2022-05-27 09:37:02 -06:00

README.md

cal-react

Embed Cal Link as a React Component

To know how to use it, follow the steps at https://developer.cal.com/embed/install-with-react

Development

Following command starts a hot reloading server yarn dev

If you are working with embed on website, don't forget to do yarn build after every change.

Running Tests

Runs tests and updates the snapshots. Right now we don't care about snapshots yarn embed-tests-quick --update-snapshots TODO

  • Playwright tests.
    • Need to what these tests should be as embed-core already have tests. We probably just need to verify that embed-core API is called appropriately.
    • It would probably be better if Playwright tests exist at one place for all embeds.
  • Distribution
    • It would be better DX to serve the unbuilt version with JSX, instead of built version with React.createElement calls. But because of WebPack loaders not running on node_modules automatically, it doesn't work automatically.
    • Right now if a typescript project uses the package, VSCode takes the user to .d.ts files instead of the functions definitions. How to solve it ?