public-offering
/
cal.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
cal.pub0.org/packages/embeds/embed-react
History
Hariom Balhara 3035412cdc
Add embed tests in CI (#2887) 
* Add embed tests in CI

* Update e2e-embed.yml

* Run quick tests only

* Ignore certain folders

* Add embed-react tests as well

* Fix commands

* Dont run unit tests

* Update playwright.config.ts

* Update playwright.config.ts

* Update playwright.config.ts

* Create correct artifcats

* Create correct artifcats

* Fi ignore path

* Update package.json

* Add back embed-react typecheck

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
 		2022-05-30 22:41:05 +05:30
..
playwright Add embed tests in CI (#2887) 2022-05-30 22:41:05 +05:30
src Fix @calcom/embed-react installation with TS project (#2870) 2022-05-27 09:37:02 -06:00
.gitignore Embed Miscellaneous Improvements and Fixes (#2499) 2022-04-25 10:03:00 +05:30
README.md Embed React improvements (#2782) 2022-05-18 16:25:30 +00:00
env.d.ts Fix @calcom/embed-react installation with TS project (#2870) 2022-05-27 09:37:02 -06:00
index.html [Feature]Booking Embed (#2227) 2022-03-31 09:45:47 +01:00
package.json Add embed tests in CI (#2887) 2022-05-30 22:41:05 +05:30
test-cal.tsx Embed React improvements (#2782) 2022-05-18 16:25:30 +00:00
tsconfig.json Add embed tests in CI (#2887) 2022-05-30 22:41:05 +05:30
vite.config.js Fix @calcom/embed-react installation with TS project (#2870) 2022-05-27 09:37:02 -06:00

README.md

cal-react

Embed Cal Link as a React Component

To know how to use it, follow the steps at https://developer.cal.com/embed/install-with-react

TODO

  • Playwright tests.
    • Need to what these tests should be as embed-core already have tests. We probably just need to verify that embed-core API is called appropriately.
    • It would probably be better if Playwright tests exist at one place for all embeds.
  • Distribution
    • It would be better DX to serve the unbuilt version with JSX, instead of built version with React.createElement calls. But because of WebPack loaders not running on node_modules automatically, it doesn't work automatically.
    • Right now if a typescript project uses the package, VSCode takes the user to .d.ts files instead of the functions definitions. How to solve it ?