public-offering
/
cal.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
cal.pub0.org/packages/embeds
History
Hariom Balhara 6dfc19247e
fix: Embed `theme` not working using Embed API (#10163) 
## What does this PR do?

Fixes #10187
See [Tests Done](https://www.loom.com/share/f03e0191b60143d8b45a505042dbfa11)

## Type of change
  - [x] Bug fix (non-breaking change which fixes an issue)

## How should this be tested?
- [x] Configure embed to use `dark` theme and verify that dark theme is shown on event booking page(when user has light theme set). This is failing in main
- Additional Tests for embed to avoid any new regression
	- [x] - Configure "auto" theme using embed API and see it reacts to system theme
	- [x] - Don't configure any theme and see that "light" theme is shown even when we switch system theme(Because User has configured light theme in App)
-  Tests outside embed to avoid any new regression
	- [x] - See that light theme is shown even after switching system theme
	- [x] - Now, switch the user theme to dark and see that it reflects the change. 

## Mandatory Tasks

 [x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.
 		2023-07-17 18:02:42 -07:00
..
embed-core fix: Embed `theme` not working using Embed API (#10163) 2023-07-17 18:02:42 -07:00
embed-react chore: removed old booker and make new booker as a default (#10053) 2023-07-11 13:31:55 +02:00
embed-snippet test: Smoke Tests for packaged embeds and build improvements (#9169) 2023-06-01 20:41:30 +00:00
README.md chore: Sync packages mismatches (#9725) 2023-06-22 15:25:37 -07:00
vite.config.js HotFix - Embed Flicker for newly converted static availability page (#3277) 2022-07-12 14:18:53 +00:00

README.md

Embeds

This folder contains all the various flavours of embeds.

core contains the core library written in vanilla JS that manages the embed. snippet contains the Vanilla JS Code Snippet that can be installed on any website and would automatically fetch the core library.

Please see the respective folder READMEs for details on them.

Publishing to NPM. It will soon be automated using changesets github action

To publish the packages. Following steps should be followed. All commands are to be run at the root.

  1. yarn changeset -> Creates changelog files and adds summary to changelog. Select embed packages only here.
  2. yarn changeset version -> Bumps the versions as required
  3. Get the PR reviewed and merged
  4. yarn publish-embed -> Releases all packages. We can't use yarn changeset publish because it doesn't support workspace: prefix removal yet. See https://github.com/changesets/changesets/issues/432#issuecomment-1016365428