public-offering
/
cal.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
cal.pub0.org/packages/embeds/embed-react
History
Hariom Balhara 6148e89425
Embed React improvements (#2782) 
* Add off support. Add getApi export.

* Add publish command

* Add embed-snippet in prod deps

* Update README

* Update package.json

Co-authored-by: Bailey Pumfleet <pumfleet@hey.com>
Co-authored-by: zomars <zomars@me.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
 		2022-05-18 16:25:30 +00:00
..
playwright Embed Code Generator: Fix Preview HTML and Embed Lib path for production (#2688) 2022-05-06 15:56:26 +00:00
src Embed React improvements (#2782) 2022-05-18 16:25:30 +00:00
.gitignore Embed Miscellaneous Improvements and Fixes (#2499) 2022-04-25 10:03:00 +05:30
README.md Embed React improvements (#2782) 2022-05-18 16:25:30 +00:00
env.d.ts [Feature]Booking Embed (#2227) 2022-03-31 09:45:47 +01:00
index.html [Feature]Booking Embed (#2227) 2022-03-31 09:45:47 +01:00
package.json Embed React improvements (#2782) 2022-05-18 16:25:30 +00:00
test-cal.tsx Embed React improvements (#2782) 2022-05-18 16:25:30 +00:00
tsconfig.json Feat/impersonate users (#2503) 2022-04-26 14:18:17 +05:30
vite.config.js Embed React improvements (#2782) 2022-05-18 16:25:30 +00:00

README.md

cal-react

Embed Cal Link as a React Component

To know how to use it, follow the steps at https://developer.cal.com/embed/install-with-react

TODO

  • Playwright tests.
    • Need to what these tests should be as embed-core already have tests. We probably just need to verify that embed-core API is called appropriately.
    • It would probably be better if Playwright tests exist at one place for all embeds.
  • Distribution
    • It would be better DX to serve the unbuilt version with JSX, instead of built version with React.createElement calls. But because of WebPack loaders not running on node_modules automatically, it doesn't work automatically.
    • Right now if a typescript project uses the package, VSCode takes the user to .d.ts files instead of the functions definitions. How to solve it ?