public-offering
/
cal.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Feedback

feat/calendar-cache-inbound
zomars 2023-10-27 12:10:30 -07:00
parent c35cdf68e7
commit f8707b6732
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/app-store/googlecalendar/lib/CalendarService.ts
View File

@ -94,6 +94,12 @@ function handleMinMax(min: string, max: string) {
} }
type FreeBusyArgs = { timeMin: string; timeMax: string; items: { id: string }[] }; type FreeBusyArgs = { timeMin: string; timeMax: string; items: { id: string }[] };
/**
* We need to parse the passed arguments in order to comply with some requirements:
* 1. Items should be sorted in order to guarantee the cache key is always the same
* 2. timeMin and timeMax should be expanded to maximize cache hits
* 3. timeMin and timeMax should not be more than 90 days apart (handled in handleMinMax)
*/
function parseArgsForCache(args: FreeBusyArgs): FreeBusyArgs { function parseArgsForCache(args: FreeBusyArgs): FreeBusyArgs {
// Sort items by id to make sure the cache key is always the same // Sort items by id to make sure the cache key is always the same
const items = args.items.sort((a, b) => (a.id > b.id ? 1 : -1)); const items = args.items.sort((a, b) => (a.id > b.id ? 1 : -1));
@ -418,17 +424,17 @@ export default class GoogleCalendarService implements Calendar {
async getCacheOrFetchAvailability(args: FreeBusyArgs): Promise<calendar_v3.Schema$FreeBusyResponse> { async getCacheOrFetchAvailability(args: FreeBusyArgs): Promise<calendar_v3.Schema$FreeBusyResponse> {
const flags = await getFeatureFlagMap(prisma); const flags = await getFeatureFlagMap(prisma);
const parsedArgs = parseArgsForCache(args);
if (!flags["calendar-cache"]) { if (!flags["calendar-cache"]) {
this.log.warn("Calendar Cache is disabled - Skipping"); this.log.warn("Calendar Cache is disabled - Skipping");
return await this.fetchAvailability(args); return await this.fetchAvailability(parsedArgs);
} }
const parsedArgs = parseArgsForCache(args);
const key = JSON.stringify(parsedArgs); const key = JSON.stringify(parsedArgs);
const cached = await this.getAvailabilityFromCache(key); const cached = await this.getAvailabilityFromCache(key);
if (cached) return cached.value as unknown as calendar_v3.Schema$FreeBusyResponse; if (cached) return cached.value as unknown as calendar_v3.Schema$FreeBusyResponse;
const data = await this.fetchAvailability(args); const data = await this.fetchAvailability(parsedArgs);
await this.setAvailabilityInCache(key, data); await this.setAvailabilityInCache(key, data);
return data; return data;
} }