public-offering
/
cal.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf: improve booking confirm authorization (#8304) 

* perf: improve booking confirm authorization

* removes unreachable code

---------

Co-authored-by: Efraín Rochín <roae.85@gmail.com>
pull/8339/head
Yagiz Nizipli 2023-04-17 19:50:34 -04:00 committed by GitHub
parent e5eb7c3906
commit ad958f10bd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
packages/trpc/server/routers/viewer/bookings.tsx
View File

@ -781,30 +781,22 @@ export const bookingsRouter = router({
}); });
const authorized = async () => { const authorized = async () => {
// if the organizer const eventType = await prisma.eventType.findFirst({
if (booking.userId === user.id) {
return true;
}
const eventType = await prisma.eventType.findUnique({
where: { where: {
id: booking.eventTypeId || undefined, id: booking.eventTypeId || undefined,
schedulingType: SchedulingType.COLLECTIVE,
}, },
select: { select: {
id: true,
schedulingType: true,
users: true, users: true,
}, },
}); });
if (
eventType?.schedulingType === SchedulingType.COLLECTIVE && return eventType && eventType.users.find((user) => booking.userId === user.id);
eventType.users.find((user) => user.id === user.id)
) {
return true;
}
return false;
}; };
if (!(await authorized())) throw new TRPCError({ code: "UNAUTHORIZED", message: "UNAUTHORIZED" }); if (booking.userId !== user.id && !(await authorized())) {
throw new TRPCError({ code: "UNAUTHORIZED", message: "UNAUTHORIZED" });
}
const isConfirmed = booking.status === BookingStatus.ACCEPTED; const isConfirmed = booking.status === BookingStatus.ACCEPTED;
if (isConfirmed) throw new TRPCError({ code: "BAD_REQUEST", message: "Booking already confirmed" }); if (isConfirmed) throw new TRPCError({ code: "BAD_REQUEST", message: "Booking already confirmed" });