public-offering
/
cal.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: update comments, replace fixme with todo

feat/alby
Roland Bewick 2023-09-26 13:52:34 +07:00
parent 509906da27
commit 8ed7ffd4fc
4 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.env.appStore.example
View File

@ -128,7 +128,7 @@ ZOHOCRM_CLIENT_SECRET=""
# ALBY
# Used for the Alby payment app / receiving Alby payments
# Get it from: https://getalby.com/developer/oauth_clients
# Set callbackUrl to /api/integrations/alby/alby-webhooks
# Set callbackUrl to YOUR_APP_DOMAIN/api/integrations/alby/alby-webhook
NEXT_PUBLIC_ALBY_CLIENT_ID=""
NEXT_PUBLIC_ALBY_CLIENT_SECRET=""

3
packages/app-store/alby/api/add.ts
View File

@ -4,7 +4,8 @@ import prisma from "@calcom/prisma";
import config from "../config.json";
// FIXME: is a custom handler really needed?
// TODO: is a custom handler really needed?
// all we need is to redirect to the setup page after installing the app
export default async function handler(req: NextApiRequest, res: NextApiResponse) {
if (!req.session?.user?.id) {
return res.status(401).json({ message: "You must be logged in to do this" });

6
packages/app-store/alby/components/AlbyPaymentComponent.tsx
View File

@ -125,8 +125,10 @@ type PaymentCheckerProps = PaymentPageProps;
function PaymentChecker(props: PaymentCheckerProps) {
// This effect checks if the booking status has changed to "ACCEPTED"
// then reload the page to show the new payment status
// FIXME: subscribe to the exact payment instead of polling bookings
// FIXME: booking success is copied from packages/features/ee/payments/components/Payment.tsx
// TODO: subscribe to the exact payment instead of polling bookings
// - we can enable payments for trpc and then you actually listen for any success there
// TODO: booking success is copied from packages/features/ee/payments/components/Payment.tsx
// - this code should be extracted into a common lib function.
const searchParams = useSearchParams();
const bookingSuccessRedirect = useBookingSuccessRedirect();
const utils = trpc.useContext();

2
packages/trpc/server/routers/loggedInViewer/integrations.handler.ts
View File

@ -169,7 +169,7 @@ export const integrationsHandler = async ({ ctx, input }: IntegrationsOptions) =
invalidCredentialIds,
teams,
isInstalled: !!userCredentialIds.length || !!teams.length || app.isGlobal,
// FIXME: remove hardcoding and add per-app validation
// TODO: remove hardcoding and add per-app validation. We can probably validate using zod schemas.
isSetup: !!(credential?.key as { account_id: string })?.account_id || app.slug !== "alby",
};
}