public-offering
/
cal.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

FIx failing tests

teste2e-radioGroupQuestion
gitstart-calcom 2023-10-30 18:45:12 +00:00
parent d2b2bd89cf
commit 8359259cb6
2 changed files with 26 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
apps/web/playwright/booking/radioGroupQuestion.e2e.ts
View File

@ -315,10 +315,10 @@ test.describe("Booking With Radio Question and Each Other Question", () => {
}); });
}); });
test.describe("Booking With Radio Question and Radio group Question", () => { test.describe("Booking With Radio Question and Phone Question", () => {
test("Radio required and Radio group required", async ({ bookingPage }) => { test("Radio required and Phone required", async ({ bookingPage }) => {
await bookingPage.addQuestion("radio", "radio-test", "radio test", true);
await bookingPage.addQuestion("radio", "radio-test", "radio test", true); await bookingPage.addQuestion("radio", "radio-test", "radio test", true);
await bookingPage.addQuestion("phone", "phone-test", "phone test", true, "phone test");
await bookingPage.updateEventType(); await bookingPage.updateEventType();
const eventTypePage = await bookingPage.previewEventType(); const eventTypePage = await bookingPage.previewEventType();
await bookingPage.selectTimeSlot(eventTypePage); await bookingPage.selectTimeSlot(eventTypePage);
@ -326,8 +326,8 @@ test.describe("Booking With Radio Question and Each Other Question", () => {
eventTypePage, eventTypePage,
placeholderText: "Please share anything that will help prepare for our meeting.", placeholderText: "Please share anything that will help prepare for our meeting.",
question: "radio", question: "radio",
fillText: "Test Radio question and Radio question (both required)", fillText: "Test Radio question and Phone question (both required)",
secondQuestion: "radio", secondQuestion: "phone",
options: bookingOptions, options: bookingOptions,
}); });
await bookingPage.rescheduleBooking(eventTypePage); await bookingPage.rescheduleBooking(eventTypePage);
@ -336,9 +336,9 @@ test.describe("Booking With Radio Question and Each Other Question", () => {
await bookingPage.assertBookingCanceled(eventTypePage); await bookingPage.assertBookingCanceled(eventTypePage);
}); });
test("Radio and Radio group not required", async ({ bookingPage }) => { test("Radio and Phone not required", async ({ bookingPage }) => {
await bookingPage.addQuestion("radio", "radio-test", "radio test", true); await bookingPage.addQuestion("radio", "radio-test", "radio test", true);
await bookingPage.addQuestion("radio", "radio-test", "radio test", false); await bookingPage.addQuestion("phone", "phone-test", "phone test", false, "phone test");
await bookingPage.updateEventType(); await bookingPage.updateEventType();
const eventTypePage = await bookingPage.previewEventType(); const eventTypePage = await bookingPage.previewEventType();
await bookingPage.selectTimeSlot(eventTypePage); await bookingPage.selectTimeSlot(eventTypePage);
@ -346,8 +346,8 @@ test.describe("Booking With Radio Question and Each Other Question", () => {
eventTypePage, eventTypePage,
placeholderText: "Please share anything that will help prepare for our meeting.", placeholderText: "Please share anything that will help prepare for our meeting.",
question: "radio", question: "radio",
fillText: "Test Radio question and Radio question (only radio required)", fillText: "Test Radio question and Phone question (only radio required)",
secondQuestion: "radio", secondQuestion: "phone",
options: { ...bookingOptions, isRequired: false }, options: { ...bookingOptions, isRequired: false },
}); });
await bookingPage.rescheduleBooking(eventTypePage); await bookingPage.rescheduleBooking(eventTypePage);

17
apps/web/playwright/fixtures/regularBookings.ts
View File

@ -170,6 +170,7 @@ export function createBookingPageFixture(page: Page) {
selectFirstAvailableTime: async () => { selectFirstAvailableTime: async () => {
await page.getByTestId("time").first().click(); await page.getByTestId("time").first().click();
}, },
fillRescheduleReasonAndConfirm: async () => { fillRescheduleReasonAndConfirm: async () => {
await page.getByPlaceholder(reschedulePlaceholderText).click(); await page.getByPlaceholder(reschedulePlaceholderText).click();
await page.getByPlaceholder(reschedulePlaceholderText).fill("Test reschedule"); await page.getByPlaceholder(reschedulePlaceholderText).fill("Test reschedule");
@ -194,6 +195,14 @@ export function createBookingPageFixture(page: Page) {
await eventTypePage.getByPlaceholder(reschedulePlaceholderText).click(); await eventTypePage.getByPlaceholder(reschedulePlaceholderText).click();
await eventTypePage.getByPlaceholder(reschedulePlaceholderText).fill("Test reschedule"); await eventTypePage.getByPlaceholder(reschedulePlaceholderText).fill("Test reschedule");
await eventTypePage.getByTestId("confirm-reschedule-button").click(); await eventTypePage.getByTestId("confirm-reschedule-button").click();
await eventTypePage.waitForTimeout(100);
if (
await eventTypePage.getByRole("heading", { name: "Could not reschedule the meeting." }).isVisible()
) {
await eventTypePage.getByTestId("back").click();
await eventTypePage.getByTestId("time").last().click();
await eventTypePage.getByTestId("confirm-reschedule-button").click();
}
}, },
assertBookingRescheduled: async (page: Page) => { assertBookingRescheduled: async (page: Page) => {
@ -248,6 +257,14 @@ export function createBookingPageFixture(page: Page) {
options.isRequired && (await fillQuestion(eventTypePage, secondQuestion, customLocators)); options.isRequired && (await fillQuestion(eventTypePage, secondQuestion, customLocators));
await eventTypePage.getByTestId(confirmButton).click(); await eventTypePage.getByTestId(confirmButton).click();
await eventTypePage.waitForTimeout(100);
if (await eventTypePage.getByRole("heading", { name: "Could not book the meeting." }).isVisible()) {
await eventTypePage.getByTestId("back").click();
await eventTypePage.getByTestId("time").last().click();
await fillQuestion(eventTypePage, question, customLocators);
options.isRequired && (await fillQuestion(eventTypePage, secondQuestion, customLocators));
await eventTypePage.getByTestId(confirmButton).click();
}
const scheduleSuccessfullyPage = eventTypePage.getByText(scheduleSuccessfullyText); const scheduleSuccessfullyPage = eventTypePage.getByText(scheduleSuccessfullyText);
await scheduleSuccessfullyPage.waitFor({ state: "visible" }); await scheduleSuccessfullyPage.waitFor({ state: "visible" });
await expect(scheduleSuccessfullyPage).toBeVisible(); await expect(scheduleSuccessfullyPage).toBeVisible();