Add return statements

pull/9078/head
Joe Au-Yeung 2022-10-05 16:02:34 -04:00
parent a5413b40ab
commit 77b89fda05
2 changed files with 13 additions and 4 deletions

View File

@ -12,7 +12,10 @@ export async function scheduleById(
{ method, query, body, userId, isAdmin, prisma }: NextApiRequest,
res: NextApiResponse<ScheduleResponse>
) {
if (body.userId && !isAdmin) res.status(401).json({ message: "Unauthorized" });
if (body.userId && !isAdmin) {
res.status(401).json({ message: "Unauthorized" });
return;
}
const safeQuery = schemaQueryIdParseInt.safeParse(query);
const safeBody = schemaScheduleBodyParams.safeParse(body);
if (!safeQuery.success) {
@ -21,8 +24,10 @@ export async function scheduleById(
}
const userSchedules = await prisma.schedule.findMany({ where: { userId: body.userId || userId } });
const userScheduleIds = userSchedules.map((schedule) => schedule.id);
if (!userScheduleIds.includes(safeQuery.data.id)) res.status(401).json({ message: "Unauthorized" });
else {
if (!userScheduleIds.includes(safeQuery.data.id)) {
res.status(401).json({ message: "Unauthorized" });
return;
} else {
switch (method) {
/**
* @swagger

View File

@ -12,6 +12,7 @@ async function createOrlistAllSchedules(
) {
if (body.userId && !isAdmin) {
res.status(401).json({ message: "Unauthorized" });
return;
} else {
if (method === "GET") {
/**
@ -59,7 +60,10 @@ async function createOrlistAllSchedules(
* description: Authorization information is missing or invalid.
*/
const safe = schemaScheduleBodyParams.safeParse(body);
if (body.userId && !isAdmin) res.status(401).json({ message: "Unauthorized" });
if (body.userId && !isAdmin) {
res.status(401).json({ message: "Unauthorized" });
return;
}
if (!safe.success) {
res.status(400).json({ message: "Invalid request body" });