From 6ec5696e50839b76a17766f45d30bd3fef217310 Mon Sep 17 00:00:00 2001 From: Hariom Balhara Date: Mon, 13 Feb 2023 18:31:40 +0530 Subject: [PATCH] More PR review fixes --- packages/features/bookings/lib/handleNewBooking.ts | 5 +---- packages/ui/components/form/inputs/Label.tsx | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/features/bookings/lib/handleNewBooking.ts b/packages/features/bookings/lib/handleNewBooking.ts index ebd997f036..eb7d20d157 100644 --- a/packages/features/bookings/lib/handleNewBooking.ts +++ b/packages/features/bookings/lib/handleNewBooking.ts @@ -352,7 +352,6 @@ function getBookingData({ }; } else { // Check if required custom inputs exist - // TODO: Run it conditionally for API. handleCustomInputs(eventType.customInputs as EventTypeCustomInput[], reqBody.customInputs); return { @@ -384,7 +383,7 @@ function getCustomInputsResponses( } } else { const responses = reqBody.responses || {}; - // Map new responses format to old customInputs format so that webhooks can still receive same values. + // Backward Compatibility: Map new `responses` to old `customInputs` format so that webhooks can still receive same values. for (const [fieldName, fieldValue] of Object.entries(responses)) { const foundACustomInputForTheResponse = eventTypeCustomInputs.find( (input) => slugify(input.label) === fieldName @@ -594,9 +593,7 @@ async function handler( const invitee = [ { - // TODO: ManageBookings: Ensure that email is there in TS as well as runtime. Right now I can save an attendee without email email: bookerEmail, - //TODO: ManageBookings: Ensure that name is there in TS as well as runtime name: bookerName, timeZone: bookingData.timeZone, language: { translate: tAttendees, locale: language ?? "en" }, diff --git a/packages/ui/components/form/inputs/Label.tsx b/packages/ui/components/form/inputs/Label.tsx index bfc45ca805..e83a81928a 100644 --- a/packages/ui/components/form/inputs/Label.tsx +++ b/packages/ui/components/form/inputs/Label.tsx @@ -4,7 +4,6 @@ export function Label(props: JSX.IntrinsicElements["label"]) { return (