public-offering
/
cal.pub0.org
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add stricter self-review guideline (#9327) 

Co-authored-by: Bailey Pumfleet <bailey@pumfleet.co.uk>
pull/9333/head
Hariom Balhara 2023-06-05 15:30:04 +05:30 committed by GitHub
parent 97fe41f3ba
commit 6aa83102e4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@ -8,8 +8,6 @@ Fixes # (issue)
Loom Video: https://www.loom.com/ Loom Video: https://www.loom.com/
--> -->
**Environment**: Staging(main branch) / Production
## Type of change ## Type of change
<!-- Please delete bullets that are not relevant. --> <!-- Please delete bullets that are not relevant. -->
@ -27,13 +25,14 @@ Fixes # (issue)
- [ ] Test A - [ ] Test A
- [ ] Test B - [ ] Test B
## Mandatory Tasks
- [ ] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.
## Checklist ## Checklist
<!-- Please remove all the irrelevant bullets to your PR --> <!-- Please remove all the irrelevant bullets to your PR -->
- I haven't read the [contributing guide](https://github.com/calcom/cal.com/blob/main/CONTRIBUTING.md) - I haven't read the [contributing guide](https://github.com/calcom/cal.com/blob/main/CONTRIBUTING.md)
- My code doesn't follow the style guidelines of this project - My code doesn't follow the style guidelines of this project
- I haven't performed a self-review of my own code and corrected any misspellings
- I haven't commented my code, particularly in hard-to-understand areas - I haven't commented my code, particularly in hard-to-understand areas
- I haven't checked if my PR needs changes to the documentation - I haven't checked if my PR needs changes to the documentation
- I haven't checked if my changes generate no new warnings - I haven't checked if my changes generate no new warnings