From 4aaf5da36dad6b64ddc536bfa115bcaedb45ba69 Mon Sep 17 00:00:00 2001
From: Purushottam Khedre <purushottamkhedre123@gmail.com>
Date: Fri, 14 Jul 2023 14:33:11 +0530
Subject: [PATCH] fix: no feedback on buttons on /getting-started page.
 (#10152)

* add isLoading type to ButtonProps type

* add loading feedback

* Update apps/web/components/getting-started/components/AppConnectionItem.tsx

Not neeeded as buttonProps.isLoading is false by default :)

---------

Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com>
---
 .../components/getting-started/components/AppConnectionItem.tsx  | 1 +
 packages/app-store/components.tsx                                | 1 +
 packages/app-store/types.d.ts                                    | 1 +
 3 files changed, 3 insertions(+)

diff --git a/apps/web/components/getting-started/components/AppConnectionItem.tsx b/apps/web/components/getting-started/components/AppConnectionItem.tsx
index 48358a189c..9431679c63 100644
--- a/apps/web/components/getting-started/components/AppConnectionItem.tsx
+++ b/apps/web/components/getting-started/components/AppConnectionItem.tsx
@@ -28,6 +28,7 @@ const AppConnectionItem = (props: IAppConnectionItem) => {
             color="secondary"
             disabled={installed}
             type="button"
+            loading={buttonProps?.isLoading}
             onClick={(event) => {
               // Save cookie key to return url step
               document.cookie = `return-to=${window.location.href};path=/;max-age=3600;SameSite=Lax`;
diff --git a/packages/app-store/components.tsx b/packages/app-store/components.tsx
index c7f2f8dc63..638098c4fd 100644
--- a/packages/app-store/components.tsx
+++ b/packages/app-store/components.tsx
@@ -34,6 +34,7 @@ export const InstallAppButtonWithoutPlanCheck = (
           onClick: () => {
             mutation.mutate({ type: props.type });
           },
+          isLoading: mutation.isLoading,
         })}
       </>
     );
diff --git a/packages/app-store/types.d.ts b/packages/app-store/types.d.ts
index 8127b37539..b2f81b08c6 100644
--- a/packages/app-store/types.d.ts
+++ b/packages/app-store/types.d.ts
@@ -34,6 +34,7 @@ export interface InstallAppButtonProps {
     renderProps: ButtonProps & {
       /** Tells that the default render component should be used */
       useDefaultComponent?: boolean;
+      isLoading?: boolean;
     }
   ) => JSX.Element;
   onChanged?: () => unknown;