From 47a663f5a90a6fd45b8b634ad576643c626af94a Mon Sep 17 00:00:00 2001
From: Alex van Andel <me@alexvanandel.com>
Date: Mon, 7 Nov 2022 21:12:12 +0000
Subject: [PATCH] Fail lint check on error (#5398)

---
 .github/workflows/lint.yml                    |  5 ++-
 packages/app-store/BookingPageTagManager.tsx  | 36 ++++++++++++-------
 .../ui/v2/core/form/MultiSelectCheckboxes.tsx |  2 +-
 3 files changed, 29 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index 10ed6b68ef..e2a7853665 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -30,7 +30,10 @@ jobs:
         if: steps.yarn-cache.outputs.cache-hit != 'true'
         run: yarn --frozen-lockfile
 
-      - name: Lint
+      - name: Test Code Linting
+        run: yarn lint
+
+      - name: Save Code Linting Reports
         run: yarn lint:report
         continue-on-error: true
 
diff --git a/packages/app-store/BookingPageTagManager.tsx b/packages/app-store/BookingPageTagManager.tsx
index e2eb311726..d22f1c5312 100644
--- a/packages/app-store/BookingPageTagManager.tsx
+++ b/packages/app-store/BookingPageTagManager.tsx
@@ -1,17 +1,19 @@
 import Script from "next/script";
 
 import { getEventTypeAppData } from "@calcom/app-store/utils";
+
 import { trackingApps } from "./eventTypeAnalytics";
 
-export type AppScript = {attrs?: Record<string, string>} & ({src: undefined, content?: string} | {src?: string, content:undefined})
+export type AppScript = { attrs?: Record<string, string> } & (
+  | { src: undefined; content?: string }
+  | { src?: string; content: undefined }
+);
 
 export default function BookingPageTagManager({
   eventType,
 }: {
   eventType: Parameters<typeof getEventTypeAppData>[0];
 }) {
-
-  
   return (
     <>
       {Object.entries(trackingApps).map(([appId, scriptConfig]) => {
@@ -19,22 +21,32 @@ export default function BookingPageTagManager({
         if (!trackingId) {
           return null;
         }
-        const parseValue = <T extends string|undefined, >(val: T ):T => val ? val.replace(/\{TRACKING_ID\}/g, trackingId) as T : val
-        
-        return scriptConfig.scripts.map((script, index)=>{
+        const parseValue = <T extends string | undefined>(val: T): T =>
+          val ? (val.replace(/\{TRACKING_ID\}/g, trackingId) as T) : val;
+
+        return scriptConfig.scripts.map((script, index) => {
           const parsedAttributes: NonNullable<AppScript["attrs"]> = {};
           const attrs = script.attrs || {};
           Object.entries(attrs).forEach(([name, value]) => {
             if (typeof value === "string") {
-              value = parseValue(value)
+              value = parseValue(value);
             }
             parsedAttributes[name] = value;
           });
-          
-          return <Script src={parseValue(script.src)} key={`${appId}-${index}`} {...{dangerouslySetInnerHTML:{
-            __html: parseValue(script.content) || ""
-          }, ...parsedAttributes}} defer />;
-        })
+
+          return (
+            <Script
+              src={parseValue(script.src)}
+              id={`${appId}-${index}`}
+              key={`${appId}-${index}`}
+              dangerouslySetInnerHTML={{
+                __html: parseValue(script.content) || "",
+              }}
+              {...parsedAttributes}
+              defer
+            />
+          );
+        });
       })}
     </>
   );
diff --git a/packages/ui/v2/core/form/MultiSelectCheckboxes.tsx b/packages/ui/v2/core/form/MultiSelectCheckboxes.tsx
index b7a8ac9335..87da95ef38 100644
--- a/packages/ui/v2/core/form/MultiSelectCheckboxes.tsx
+++ b/packages/ui/v2/core/form/MultiSelectCheckboxes.tsx
@@ -29,7 +29,7 @@ const InputOption: React.FC<OptionProps<any, boolean, GroupBase<any>>> = ({
     <components.Option
       className={classNames(
         className,
-        "dark:bg-darkgray-100 text-[inherit] !flex !cursor-pointer !py-3",
+        "dark:bg-darkgray-100 !flex !cursor-pointer !py-3 text-[inherit]",
         isFocused && "dark:!bg-darkgray-200 !bg-gray-100",
         isSelected && "dark:!bg-darkgray-300 !bg-neutral-900"
       )}