From 2eedf74eb73a5254b880d5176a74d894704ec46d Mon Sep 17 00:00:00 2001
From: GitStart <1501599+gitstart@users.noreply.github.com>
Date: Thu, 21 Jul 2022 17:05:13 +0100
Subject: [PATCH] Apply suggestions from code review (#3480)

Co-authored-by: gitstart <gitstart@users.noreply.github.com>
Co-authored-by: Peer Richelsen <peer@cal.com>
---
 apps/web/components/availability/Schedule.tsx | 27 ++++++++++---------
 apps/web/public/static/locales/en/common.json |  1 +
 apps/web/public/static/locales/fr/common.json |  1 +
 3 files changed, 17 insertions(+), 12 deletions(-)

diff --git a/apps/web/components/availability/Schedule.tsx b/apps/web/components/availability/Schedule.tsx
index 22a60acb19..01df625fc6 100644
--- a/apps/web/components/availability/Schedule.tsx
+++ b/apps/web/components/availability/Schedule.tsx
@@ -8,7 +8,8 @@ import { GroupBase, Props } from "react-select";
 import dayjs, { Dayjs, ConfigType } from "@calcom/dayjs";
 import { useLocale } from "@calcom/lib/hooks/useLocale";
 import Button from "@calcom/ui/Button";
-import Dropdown, { DropdownMenuTrigger, DropdownMenuContent } from "@calcom/ui/Dropdown";
+import Dropdown, { DropdownMenuContent } from "@calcom/ui/Dropdown";
+import { Tooltip } from "@calcom/ui/Tooltip";
 
 import { defaultDayRange } from "@lib/availability";
 import { weekdayNames } from "@lib/core/i18n/weekday";
@@ -202,7 +203,7 @@ export const DayRanges = ({
   const { setValue, watch } = useFormContext();
   // XXX: Hack to make copying times work; `fields` is out of date until save.
   const watcher = watch(name);
-
+  const { t } = useLocale();
   const { fields, replace, append, remove } = useFieldArray({
     name,
   });
@@ -242,16 +243,18 @@ export const DayRanges = ({
           </div>
           {index === 0 && (
             <div className="absolute top-2 right-0 text-right sm:relative sm:top-0 sm:flex-grow">
-              <Button
-                className="text-neutral-400"
-                type="button"
-                color="minimal"
-                size="icon"
-                StartIcon={PlusIcon}
-                onClick={handleAppend}
-              />
+              <Tooltip content={t("add_time_availability") as string}>
+                <Button
+                  className="text-neutral-400"
+                  type="button"
+                  color="minimal"
+                  size="icon"
+                  StartIcon={PlusIcon}
+                  onClick={handleAppend}
+                />
+              </Tooltip>
               <Dropdown>
-                <DropdownMenuTrigger asChild>
+                <Tooltip content={t("duplicate") as string}>
                   <Button
                     type="button"
                     color="minimal"
@@ -259,7 +262,7 @@ export const DayRanges = ({
                     StartIcon={DuplicateIcon}
                     onClick={handleAppend}
                   />
-                </DropdownMenuTrigger>
+                </Tooltip>
                 <DropdownMenuContent>
                   <CopyTimes
                     disabled={[parseInt(name.substring(name.lastIndexOf(".") + 1), 10)]}
diff --git a/apps/web/public/static/locales/en/common.json b/apps/web/public/static/locales/en/common.json
index 6e8e59f94a..a0c35c80ac 100644
--- a/apps/web/public/static/locales/en/common.json
+++ b/apps/web/public/static/locales/en/common.json
@@ -378,6 +378,7 @@
   "enable": "Enable",
   "code": "Code",
   "code_is_incorrect": "Code is incorrect.",
+  "add_time_availability": "Add new time slot",
   "add_an_extra_layer_of_security": "Add an extra layer of security to your account in case your password is stolen.",
   "2fa": "Two-Factor Authentication",
   "enable_2fa": "Enable two-factor authentication",
diff --git a/apps/web/public/static/locales/fr/common.json b/apps/web/public/static/locales/fr/common.json
index 324d849350..579c41423e 100644
--- a/apps/web/public/static/locales/fr/common.json
+++ b/apps/web/public/static/locales/fr/common.json
@@ -130,6 +130,7 @@
   "dismiss": "Ignorer",
   "no_data_yet": "Aucune donnée pour l'instant",
   "ping_test": "Test ping",
+  "add_time_availability": "Ajouter une disponibilité horaire",
   "add_to_homescreen": "Ajoutez cette application à l'écran d'accueil de votre mobile pour un accès plus rapide et une meilleure expérience.",
   "upcoming": "À venir",
   "recurring": "Récurrent",