From 2aa0188418ae8b69a49df490dbd64c09798f06a2 Mon Sep 17 00:00:00 2001 From: Nadeem Ashraf Date: Wed, 9 Aug 2023 03:03:58 +0530 Subject: [PATCH] fix: #10553 - "Apps" child items not highlighted when selected (#10565) Co-authored-by: Udit Takkar --- packages/features/shell/Shell.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/features/shell/Shell.tsx b/packages/features/shell/Shell.tsx index 9d007d2489..10b9a70772 100644 --- a/packages/features/shell/Shell.tsx +++ b/packages/features/shell/Shell.tsx @@ -655,9 +655,10 @@ const NavigationItem: React.FC<{ href={item.href} aria-label={t(item.name)} className={classNames( - "[&[aria-current='page']]:bg-emphasis text-default group flex items-center rounded-md px-2 py-1.5 text-sm font-medium", + "text-default group flex items-center rounded-md px-2 py-1.5 text-sm font-medium", + item.child ? `[&[aria-current='page']]:bg-transparent` : `[&[aria-current='page']]:bg-emphasis`, isChild - ? `[&[aria-current='page']]:text-emphasis hidden h-8 pl-16 lg:flex lg:pl-11 [&[aria-current='page']]:bg-transparent ${ + ? `[&[aria-current='page']]:text-emphasis [&[aria-current='page']]:bg-emphasis hidden h-8 pl-16 lg:flex lg:pl-11 ${ props.index === 0 ? "mt-0" : "mt-px" }` : "[&[aria-current='page']]:text-emphasis mt-0.5 text-sm",